jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Chat with groups + AI chat UI and logic overhaul

Open InAnYan opened this issue 1 year ago • 8 comments

Changes include:

  1. AI chat UI - separated to components (easier to handle and modify AI chat code)
  2. Any kinds of errors while chatting and file ingestion are now stored in notifications (button in AI chat in lower left corner) - simplifies code, user flow and will be useful for groups.
  3. Chat history is maintained differently. It's now a simple ObservableList<ChatMessage>, so for every BibEntry there is a chat, and it's easy to get that chat. So chat history is separated in a facade ChatHistoryService, that works fine while running JabRef, and an implementation ChatHistoryImplementation, implementation is responsible for loading and storing chat history.
  4. Introduced IngestionStatus and IngestionService: that way we could easily monitor the state of ingestion.
  5. Intro

There are problems with PR:

  1. It's buggy (but I think they are solvable).
  2. Notifications panel was not discussed with mentors (so it's a brand new idea), and it looks clunky.

New UI:

Group chat: image

Notifications: image

Mandatory checks

  • [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [ ] Tests created for changes (if applicable)
  • [ ] Manually tested changed features in running JabRef (always required)
  • [ ] Screenshots added in PR description (for UI changes)
  • [ ] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [ ] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

InAnYan avatar Aug 22 '24 11:08 InAnYan

can you show some screenshots?

Siedlerchr avatar Aug 22 '24 11:08 Siedlerchr

I'm only one step towards chat with groups. The last push won't compile, just because, I need some rest :)

InAnYan avatar Aug 23 '24 16:08 InAnYan

Okay, now PR is working.

When I finally add this group chat window I will refine the PR.

(Just one step left)

InAnYan avatar Aug 24 '24 09:08 InAnYan

Is this missing task icon an issue of this PR or a general JabRef one?

image

koppor avatar Aug 24 '24 13:08 koppor

Is this missing task icon an issue of this PR or a general JabRef one?

image

it's a general issue (I think) https://github.com/JabRef/jabref/issues/11572

InAnYan avatar Aug 24 '24 13:08 InAnYan

Okay, chat with groups is here.

Now, the PR should be tested thoroughly and polished...

InAnYan avatar Aug 24 '24 13:08 InAnYan

Yay, more new code!

InAnYan avatar Aug 26 '24 11:08 InAnYan

I did something terribly wrong with Git

(But it seems it's all right)

InAnYan avatar Aug 26 '24 20:08 InAnYan

From UI perspective, https://github.com/InAnYan/jabref/issues/169 is kind of blocker, but it seems to be unfixable for now. Thus, we go ahead and fix later.

koppor avatar Aug 29 '24 11:08 koppor

The PR's number is # 11 666

InAnYan avatar Sep 04 '24 05:09 InAnYan