jabref icon indicating copy to clipboard operation
jabref copied to clipboard
verified publisher icon JabRef

Jaxb context citavi xml importer 9539

Open psyren99 opened this issue 1 year ago • 11 comments

Mandatory checks

  • [x] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [ ] Tests created for changes (if applicable)
  • [x] Manually tested changed features in running JabRef (always required)
  • [ ] Screenshots added in PR description (for UI changes)
  • [x] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [x] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

psyren99 avatar Aug 14 '24 16:08 psyren99

should i open a new branch? seems to still have an issue.

psyren99 avatar Aug 14 '24 18:08 psyren99

should i open a new branch? seems to still have an issue.

GitHub shows an OKish diff.

However, the tests fail. Can you please have a look?

image

koppor avatar Aug 15 '24 22:08 koppor

Just a quick review with the obvious catches.

Additnoally, are these files really needed - or are these just results of adding extracted files?

image

removed these files

psyren99 avatar Aug 15 '24 23:08 psyren99

something is wrong with file recognition. Is an unzip missing?

image

koppor avatar Aug 19 '24 22:08 koppor

Nothing missing, not sure why it's not reading?

psyren99 avatar Aug 21 '24 00:08 psyren99

This refs #9539

koppor avatar Aug 21 '24 18:08 koppor

@psyren99 I fixed the merge conflicts. Please check the failing GitHub workflows and fix accordingly.

koppor avatar Aug 22 '24 18:08 koppor

Converted to draft, since many tests are red.

koppor avatar Aug 24 '24 12:08 koppor

Converted to draft, since many tests are red.

@koppor i cant find the reason why these tests are failing

psyren99 avatar Sep 05 '24 21:09 psyren99

Closing this issue due to inactivity :zzz: Please ping us if you intend to resume work on this one.

koppor avatar Oct 18 '24 16:10 koppor

Closing this issue due to inactivity 💤 Please ping us if you intend to resume work on this one.

Having the same issue with with parsing the file correctly, if I can I would like to keep working on it

psyren99 avatar Oct 18 '24 23:10 psyren99

unable to get anything to come out when testing the file. since its been awhile, it may be better off if someone else took this

psyren99 avatar Nov 11 '24 23:11 psyren99