jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Improve arxiv parsing

Open tobiasdiez opened this issue 1 year ago • 8 comments

JabRef version

5.13 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • [X] I made a backup of my libraries before testing the latest development version.
  • [X] I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Have an entry with fields note: arXiv: 1503.05173 version: 1 and institution: arxiv and eid: arXiv:1503.05173
  2. Run cleanup entries with "Move preprint information from 'URL' and 'journal' field to the 'eprint' field"
  3. Entry is not changed.

Instead, one would expect that the information in these fields is also moved to the correct information in the eprint* fields.

image

Appendix

...

Log File
Paste an excerpt of your log file here

tobiasdiez avatar May 20 '24 01:05 tobiasdiez

Hi @tobiasdiez, I would like to work on this issue. Could you please assign it to me? Thanks!

narasimhareddyputta94 avatar Jun 19 '24 04:06 narasimhareddyputta94

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

~~One needs to adapt EprintCleanup.~~

koppor avatar Aug 07 '24 21:08 koppor

Hi @koppor I have made the necessary changes to address this issue in my forked repository. Could you please assign this issue to me? I would like to raise a pull request for the changes. Thank you!

18bce133 avatar Aug 13 '24 22:08 18bce133

Hi @koppor I have made the necessary changes to address this issue in my forked repository.

Deep link: https://github.com/JabRef/jabref/compare/main...18bce133:jabref:fix-11306

Could you please assign this issue to me? I would like to raise a pull request for the changes. Thank you!

You can submit a PR without being assigned.

I think, the eprint field needs to contain more information.

koppor avatar Aug 13 '24 23:08 koppor

@tobiasdiez Can you please detail which information you expect in the eprint field? Is there any description of the syntax?

The current proposal just sets 1503.05173 and drops institution and version. I don't think, this is expected. Is it?

koppor avatar Aug 13 '24 23:08 koppor

@tobiasdiez Can you please detail which information you expect in the eprint field? Is there any description of the syntax?

The current proposal just sets 1503.05173 and drops institution and version. I don't think, this is expected. Is it?

Eprint should be just the id perhaps with the version (e.g. 1503.05173v2), "arxiv" should be in eprinttype. See https://tex.stackexchange.com/questions/49757/what-should-an-entry-for-arxiv-entries-look-like-for-biblatex

tobiasdiez avatar Aug 13 '24 23:08 tobiasdiez

Hello @tobiasdiez and @koppor, I've implemented the requested changes to ensure the Eprint field contains the ID along with the version. I've submitted a pull request with these modifications. Could you please review the PR and the code changes? I'm open to any feedback or suggestions for further improvements if needed. Thank you for your guidance on this issue.

18bce133 avatar Aug 14 '24 21:08 18bce133