jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Published 20 hours ago • verified publisher icon JabRef

Make External Changes Resolver dialog scrollable

Open koppor opened this issue 10 months ago • 6 comments

The box in the "External Changes Resolver" should be scrollable

  1. Create a new library with a few groups and assign some entries to them
  2. Outside of JabRef, open the bib file in a text editor, scroll down to the end of JabRef and modify the group structure, e.g., change the group name or add new group by copy and paste
  3. Wait for the dialog "This library has been modified by another program"
  4. Click on Review Changes
  5. See the metadata like in the screenshot

image

koppor avatar Apr 18 '24 08:04 koppor

Hey, @sambujangfofana and I are students from the University of Michigan. We are currently working on a project wherein we have to contribute to a Github repository(https://eecs481.org/hw6.html). We are pretty interested in this issue and would want to work on it. We hope to submit a pull request this week. Could we be assigned this issue?

aaronphilip19 avatar Apr 22 '24 03:04 aaronphilip19

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

github-actions[bot] avatar Apr 22 '24 06:04 github-actions[bot]

@aaronphilip19 are you still on it or can I unassign you?

ThiloteE avatar May 20 '24 19:05 ThiloteE

@ThiloteE Can I work on this issue? If you would like, you can assign this issue to me!

abimael-turing avatar May 20 '24 21:05 abimael-turing

@abimael-turing for now, this issue is still reserved. image

ThiloteE avatar May 20 '24 23:05 ThiloteE

@aaronphilip19 are you still on it or can I unassign you?

Hi, we weren't able to solve it so you can unassign me.

aaronphilip19 avatar May 21 '24 23:05 aaronphilip19

Hello @koppor and @ThiloteE . Is help still wanted for this issue ? If so, could you please assign it to me ?

I made some investigation and was able to make the Metadata change details view scrollable and to wrap the text in the Group change details view.

I also see a TODO in the DatabaseChangeDetailsViewFactory regarding pattern matching. As Java 21 is now proposing it, would you like me to give it a try at the same time as we are working in the same package (for instance, I split the work in two commits for the review) ?

alexandre-cremieux avatar Jun 09 '24 19:06 alexandre-cremieux

Thanks for your interest. Yes, two separate commits/pull-requests are fine.

ThiloteE avatar Jun 09 '24 20:06 ThiloteE

Thanks for you answer @ThiloteE. Just to be clear about what you would like ?

  • two separate commits in same pull request
  • or two different pull-requests (one for this issue, the other one for the TODO related to pattern matching)

alexandre-cremieux avatar Jun 09 '24 21:06 alexandre-cremieux

To be honest, I think either one is fine. As long as you have a good commit message that summarizes and lists both features it should be fine, if its in one PR, but obviously in case the pull-request becomes rather large, then disentangling the two might be better for debugging and reviewing. Also, two distinct features will be introduced, thereby having two separate pull-requests / commits is fine for keeping track of changes in JabRef. I don't have a strong opinion on this. Your choice.

ThiloteE avatar Jun 09 '24 21:06 ThiloteE

Okay, then I will open one PR and let you comment it. If needed, I will split it later. Thanks.

alexandre-cremieux avatar Jun 09 '24 21:06 alexandre-cremieux