jabref icon indicating copy to clipboard operation
jabref copied to clipboard

bottom menu items not visible

Open AdamWysokinski opened this issue 10 months ago • 27 comments

JabRef version

5.13 (latest release)

Operating system

GNU / Linux

Details on version and operating system

Debian

Checked with the latest development build (copy version output from About dialog)

  • [X] I made a backup of my libraries before testing the latest development version.
  • [X] I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Bottom menu items are not visible after upgrading to 5.13, see attached screenshot.

scrot

Appendix

No response

AdamWysokinski avatar Apr 03 '24 21:04 AdamWysokinski

That is weird! Which desktop environment are you using? Gnome? Kde?
Does a version from here (with newer JavaFX https://builds.jabref.org/jdk-ea/ work correctly ?)

Siedlerchr avatar Apr 03 '24 22:04 Siedlerchr

That's i3. The issue is the same in the newer JavaFX version. Changing the menu items padding (in theme css) does not help.

AdamWysokinski avatar Apr 03 '24 22:04 AdamWysokinski

@AdamWysokinski What version of JabRef did you upgrade from? From what I can see it looks like a rendering issue with JavaFX, did you try to restart the computer? Maybe when the window manager gets reinitialized, it will fix itself. Also, did you notice the problem in other menus or just the File one?

HoussemNasri avatar Apr 03 '24 22:04 HoussemNasri

I have the same issue under manjaro xfce. I tried both jabref and jabref-bin from aur. I also tried to restart the computer. It happens to all menus and also the contextual menu.

Btw, I don't know whether it is related, but the override default font size setting is not functional for the bib entries after restarting jabref.

duguyipiao avatar Apr 04 '24 01:04 duguyipiao

@AdamWysokinski What version of JabRef did you upgrade from? From what I can see it looks like a rendering issue with JavaFX, did you try to restart the computer? Maybe when the window manager gets reinitialized, it will fix itself. Also, did you notice the problem in other menus or just the File one?

After restarting the system, this issue is still present. All menus are affected. The context menu as well.

AdamWysokinski avatar Apr 04 '24 18:04 AdamWysokinski

@AdamWysokinski What version of JabRef did you upgrade from?

HoussemNasri avatar Apr 04 '24 23:04 HoussemNasri

In JabRef 5.13-PullRequest10808.81--2024-01-20--34082ca menus work fine.

AdamWysokinski avatar Apr 05 '24 06:04 AdamWysokinski

The issue is also present in 5.14 from https://builds.jabref.org/main/

AdamWysokinski avatar Apr 05 '24 13:04 AdamWysokinski

@AdamWysokinski can you also test the 5.14 with jfx23 https://builds.jabref.org/jdk-ea/ variant here? (portable is probably fine enough)

Siedlerchr avatar Apr 05 '24 16:04 Siedlerchr

Also, please test https://builds.jabref.org/pull/11155/merge/. It uses JavaFX 21.0.2 which is the same version used in JabRef 5.13-PullRequest10808.81--2024-01-20--34082ca.

HoussemNasri avatar Apr 05 '24 18:04 HoussemNasri

@AdamWysokinski can you also test the 5.14 with jfx23 https://builds.jabref.org/jdk-ea/ variant here? (portable is probably fine enough)

No change, same issue.

AdamWysokinski avatar Apr 05 '24 18:04 AdamWysokinski

Also, please test https://builds.jabref.org/pull/11155/merge/. It uses JavaFX 21.0.2 which is the same version used in JabRef 5.13-PullRequest10808.81--2024-01-20--34082ca.

No change, same issue.

AdamWysokinski avatar Apr 05 '24 19:04 AdamWysokinski

That's very weird, since the menu is a popup window and has it's own rendering. The fact that the rendering glitch is not a rectangle is even weirder.

tsayao avatar Apr 06 '24 15:04 tsayao

It it i3/Xorg or Sway/Wayland ?

tsayao avatar Apr 06 '24 15:04 tsayao

It it i3/Xorg or Sway/Wayland ?

i3/Xorg. Same issue with NVidia and AMD cards.

AdamWysokinski avatar Apr 06 '24 15:04 AdamWysokinski

It's a sizing issue - but only happens on i3 according to my tests.

tsayao avatar Apr 06 '24 16:04 tsayao

@tsayao Thank you very much for your investigation!

Siedlerchr avatar Apr 06 '24 17:04 Siedlerchr

Proposed a fix here: https://github.com/openjdk/jfx/pull/1437

tsayao avatar Apr 06 '24 17:04 tsayao

I can indeed confirm that on i3 on JR 5.13 and 5.14, but I've not had this issue with JR 5.12, see my screenshoots: jr-cutoff-menus jr-cutoff-menus2

Generally, on i3, I've had JavaFX layouting problems for years, but fortunately never some missing menu items.

Hope there is an easy fix as it did still work on JR 5.12.

ytzemih avatar Apr 10 '24 11:04 ytzemih

Thanks, @tsayao for having had a go on this.

ytzemih avatar Apr 10 '24 11:04 ytzemih

It seems that I have solved the problem: compton (Linux xorg compositor) was not running. After re-enabling it menus look fine. Will test more and report.

AdamWysokinski avatar May 21 '24 17:05 AdamWysokinski

@AdamWysokinski @ytzemih The fix for i3 was merged a couple of days ago into javafx 23, so you can try out this version here with the new javafx:

https://builds.jabref.org/jdk-ea/

Thanks again @tsayao for the fix!

Siedlerchr avatar May 21 '24 17:05 Siedlerchr

Thanks, that one is perfect!

AdamWysokinski avatar May 21 '24 18:05 AdamWysokinski

That one works for me as well. Thanks a lot for finding a fix.

ytzemih avatar May 22 '24 05:05 ytzemih

Hi, when is this fix going to be included in the main branch? Just wondering, today I updated to the last nightly build and the issue is still there. Are there further things to be checked? Thanks a lot for a comment.

ytzemih avatar Jun 20 '24 12:06 ytzemih

@ytzemih We have to wait for the new javafx release around July. You can use the variant from the jdk ea build folder here https://builds.jabref.org/jdk-ea/
They will inlcude the latest jabref code combined with newer jdk versions, but are not build everytime

Siedlerchr avatar Jun 20 '24 13:06 Siedlerchr

Thanks, @Siedlerchr, for the clarification and the update. Much appreciated.

ytzemih avatar Jun 20 '24 13:06 ytzemih

With JabRef 5.16--2024-09-20--5ac788c, this issue seems to be solved for me now. Thanks.

ytzemih avatar Sep 24 '24 07:09 ytzemih