J. George
J. George
We will start fixing it tomorrow as it is a major bug. Please let us know by end of this day if you object.
Hi all, We are also happy to just correct these issues according to @kaueltzen 's suggestions. It will, however, be a breaking change. But as this seems wrong, we should...
We are a team of 2-3 people working on this. It is simply not yet implemented. The code has been built for PBE POTCARs, 54. This is also the default...
We could add a note that it has only been implemented for PBE_54 if there isn't already.
> **Important note for this PR:** this technically counts as a breaking change. I can imagine cases whereby users are generating and storing space group strings in a database, for...
As far as I see it, all review requests have been addressed by @kaueltzen . Would be great if this could be merged if the changes are fine.
Oh, now there are some conflicts 🫠
@shyuep is there anything that still needs to be done here? We would be very happy if this could be merged and fixed.
@shyuep thank you!