broadcastchannel-polyfill icon indicating copy to clipboard operation
broadcastchannel-polyfill copied to clipboard

change self to window

Open SeyyedKhandon opened this issue 4 years ago • 3 comments

SeyyedKhandon avatar Nov 08 '20 07:11 SeyyedKhandon

@JSmith01 could you please approve?

BPreisner avatar Dec 01 '20 18:12 BPreisner

@SeyyedKhandon I would also suggest a change so this will get a chance to run in CI environments. I mean the self in the IIFE invocation can be completely removed, and I would rather go for the check at the begging of the function body:

if (typeof self === 'undefined') {
    return null;
} 

... rename global to self in the function body

BPreisner avatar Dec 04 '20 14:12 BPreisner

@JSmith01 @GreLI

SeyyedKhandon avatar May 21 '21 09:05 SeyyedKhandon