JunsuChoi

Results 62 comments of JunsuChoi

@hermet Do you have any comments for updates? At the time this patch was written, it wasn't a necessary thing. There were comments related to hashing, but I can't pay...

> Yet my question is whether `tvg::Paint` needs to return the name as a string or not. If so, how can it be done without any cost. On consideration. It...

> @JSUYA Please have a look at this. I'm not sure about this feature for SVG since there have been no practical requirements so far. It will just make things...

Hi @mihashco @JoogabYun Can you review this issue and performance check? https://github.com/Samsung/rlottie/commit/19164367c99363d4b86ecc93b1bbc318faff2a4a#commitcomment-121705281

> > files with info about problems - [BrokenLottie.7z.zip](https://github.com/thorvg/thorvg/files/14647276/BrokenLottie.7z.zip) - (this is 7zip archive, but named zip, to be able to post it here) > @JSUYA ok to close? Hi,...

> files - [thorvg.zip](https://github.com/thorvg/thorvg/files/14693550/thorvg.zip) - large stroke issue SVG_FILE_123165.png https://github.com/thorvg/thorvg/issues/2084 - Empty path issue SVG_FILE_64471.svg SVG_FILE_14088.svg -> Use animate(unsupported) element SVG_FILE_14090.svg -> Use animate(unsupported) element SVG_FILE_14094.svg -> Use animate(unsupported) element...

> New pack of broken files - [brokenFiles.zip](https://github.com/thorvg/thorvg/files/14873406/brokenFiles.zip) After #2193, 8 broken files remain. I analyzed the problematic syntax for each file. In case 7 can be solved in the...

> @JSUYA hello, it's about performance? Hi @hermet I think this is a bug. It takes a long time to calculate, as if it is stuck in an infinite loop.

There is more case. The while loop of tvgSwRle.cpp: _cubicTo() runs for a very long time. If there are more many paths with such large numbers, the app look like...