JunsuChoi comments

Results 62 comments of


                                            JunsuChoi

loader/svg: Improve valid check for url(#id)

+) Filling the invalid gradient id with black should be considered separately.

loader/svg: Improve valid check for url(#id)

@MewPurPur > url(#) is valid syntax, but references an empty ID, and empty IDs are invalid, therefore should be transparent. I modified to find empty cases. At least in some...

Introduce TVG Window port

Is this in progress? I thought [this suggestion](https://github.com/thorvg/thorvg/issues/1244#issuecomment-1666604901) was very interesting. So I was going to start [working on it](https://github.com/JSUYA/thorvg/commit/e0acbd63db9eb83c493357cdee9b42c35bd4c7c9), but I was personally very busy. (My commit is meaningless...

infra: Add debugging tool in action(win build)

> 2. This usage is optional, and tmate will be terminated after a designated time. So, I believe applying this guide would be the best option for us. https://github.com/marketplace/actions/debugging-with-tmate#manually-triggered-debug I...

infra: Add debugging tool in action(win build)

> @JSUYA The benefit of the manual trigger method is that we can trigger Tmate only when the test fails for a valid reason. Otherwise, every time you push commits,...

infra: Add debugging tool in action(win build)

> workflow_dispatch(tmate) works on a branch: Oh I didn't see there was a dropbox to select branch there. Thank you for check! > a. We haven't received any requests for...

[draft]extension/window: Introduce tvg::Window based on GLFW

tvg::Window usage ```cpp if (tvg::Initializer::init(tvgEngine, threads) == tvg::Result::Success) { window = tvg::Window::gen(WIDTH, HEIGHT, "GLFW Window Example"); window->update([=](tvg::Scene* main_scene) { auto shape1 = tvg::Shape::gen(); //... main_scene->push(move(shape1)); auto picture = tvg::Picture::gen(); //......