JunsuChoi

Results 62 comments of JunsuChoi

I thought about how to use the existing paint loader. 1) ``` auto picture = tvg::Picture::gen() picture->load("a.json"); picture->size(width, height); auto t = picture->totalFrame(); auto d = picture->duration(); picture->setFrame(FrameNo); canvas->push(picture); ```...

I agree too with picture become complexity. and I am not against providing a Loader. There are just a few things to be concerned about. ```auto svg = unique_ptr(loader->load(".svg", ...));```...

Brief (my) plan - Create a temporary json loader in the current loader (https://github.com/Samsung/thorvg/pull/1021) - Content loading based on first frame ~~- Make parser code (with rapidjson)~~ - Make tvg...

@hermet How about this way? Lottie case ``` auto lottie = tvg::Animation::gen(); lottie->load("abc.json"); auto totalFrame = lottie->totalFrame(); auto picture = lottie->picture(100, 100/* size w x h */, 10 /*frame*/); //or...

https://github.com/Samsung/thorvg/issues/951

> Hmm, meson can create a VS solution. I use this with meson 0.63.0: wow Thank you for good information. I don't think this PR is needed anymore. :) >...

https://github.com/Samsung/thorvg/pull/961 https://github.com/Samsung/thorvg/pull/965 I hope these PRs solve it :)

> I have tried with the latest code. Just one test error now, but it's a new one: > > ``` > ../test/testPicture.cpp(358): FAILED: > {Unknown expression after the reported...

> @JSUYA I just tried it now. Still the same error - unfortunately it did not resolve the issue. [testlog.txt](https://github.com/Samsung/thorvg/files/7458308/testlog.txt) > > ``` > ../test/testPicture.cpp(358): FAILED: > {Unknown expression after...