JSqlParser icon indicating copy to clipboard operation
JSqlParser copied to clipboard

Published 20 hours ago • verified publisher icon JSQLParser

WIP: preparing fixes for PR.

Open wheredevel opened this issue 6 years ago • 4 comments

wheredevel avatar Jul 03 '18 12:07 wheredevel

Coverage Status

Coverage decreased (-2.07%) to 83.852% when pulling cdc080ba2919e4aa4f4043159d11dd463c28c3b7 on wheredevel:fixes into b76e6393db72d62ebfb3817eb069e60a4f73f919 on JSQLParser:master.

coveralls avatar Jul 03 '18 22:07 coveralls

So back from Holidays.

So we are going for the huge commit, do we? Should I look at the conflicting files or do you? Whats the next step?

wumpz avatar Jul 26 '18 19:07 wumpz

Hi @wumpz . I already solved all the conflicts. The PR passes the tests.
I saw a couple of commits you did after its submission.
If you could merge it with the current master - that would be great.
Let me know if my help is needed.

wheredevel avatar Jul 27 '18 15:07 wheredevel

This PR is quite old and seems to be abandoned although I spotted some very good additions about MS SQL specific Statements and Server Hints.

Is there anyone taking responsibility of that PR or should I just try to salvage the scraps? There has been a lot of good work done and it would be very sad to lose this contribution.

manticore-projects avatar Jul 28 '21 03:07 manticore-projects

This thing is dead. Please resubmit properly when there is any serious interest.

manticore-projects avatar Sep 12 '23 09:09 manticore-projects