hegel icon indicating copy to clipboard operation
hegel copied to clipboard

Published 20 hours ago • verified publisher icon JSMonk

README missing in npm tarball

Open Raynos opened this issue 5 years ago • 4 comments
trafficstars

  • https://www.npmjs.com/package/@hegel/cli
  • https://www.npmjs.com/package/@hegel/core

I don't know how your publishing up to npm but I strongly recommend you update your build step to also copy the ./README.md into ./packages/core/build/README.md so that it's published with the npm tarball.

Raynos avatar May 24 '20 11:05 Raynos

Oh, thank you 🙏 . I will add it soon.

JSMonk avatar May 24 '20 12:05 JSMonk

Implemented in https://github.com/JSMonk/hegel/pull/251

Raynos avatar May 24 '20 14:05 Raynos

@Raynos apparently i have broken your fix with this #252

i was thinking to restore your implementation but i am confused. should not readme describe package? and if so then we need seperate readme for @hegel/cli and @hegel/core

thecotne avatar Jun 10 '20 06:06 thecotne

A seperate README for @hegel/cli and @hegel/core would be good.

The same README for both is better then no readme for either.

I wanted to add a README instead of splitting the README into two README files.

Raynos avatar Jun 10 '20 10:06 Raynos