Jeppe Reinhold

Results 228 comments of Jeppe Reinhold

I think some merging has gone bad, as this now does `const files = glob(...)` twice right after each other.

Strictly speaking we can't actually replace these `chalk` colors with `picocolors`, because the APIs are not compatible, and the `colors` export is a "public API" in node-logger (not documented). So...

I'm pretty certain that this is because Storybook 7 doesn't support React 19, only Storybook 8 does. Storybook's React DOM shim package (`@storybook/react-dom-shim`) selects the right React mounting APIs based...

FYI, even though we just merged https://github.com/storybookjs/storybook/pull/28981 to replace `lodash` with `es-toolkit`, that shouldn't block this PR from moving forward, because I still think the approach in this PR is...

Good question, I'd say target `next` directly here. Perhaps that other target branch is now entirely superseded by our done lodash migration @valentinpalkovic ?

Could you try removing the `getAbsolutePath` call from the svelte addon, and just have the plain string?

Okay. Please share a minimal reproduction repo that we can investigate. See https://storybook.js.org/docs/contribute/how-to-reproduce

> Yeah I'm actually thinking this is a Svelte 5 compatibility issue, I think I will just wait till Svelte 5 is released and Storybook has full support for Svelte...

@domuk-k did you try this? https://github.com/storybookjs/addon-svelte-csf/issues/189#issuecomment-2227036083 If that doesn't work, we'd need a minimal reproduction to be able to investigate further.

@ghengeveld @ndelangen I wonder if our new way of finding stories here, also fixes https://github.com/storybookjs/storybook/issues/29572. We should try it out in QA.