Jan Peer Stöcklmair

Results 84 comments of Jan Peer Stöcklmair

Alright. I the next version `4+` a lot of bugs will be fixed. Yours should be fixed as well. To be sure I will add a test case specific to...

Alright, thanks for the update, I will add this to my tests. I think it is kinda confusing right now with the versions. Following should be true: - `rename-css-selectors` version:...

@RealOrangeOne based on your list above, are just the tests missing? So basically your rewrite is almost ready right?

Hm, I tried earlier to set up the tests, but all failed. So I am quite confused - also they failed here on this Travis.

I guess I got the mistake. [Here](https://travis-ci.org/RealOrangeOne/react-native-mock/jobs/220325004#L197) it seems, that it does install `[email protected]` which requires `[email protected]`. But the given react version is `[email protected]` which does not satisfy the peer...

Unluckily I saw that you need more than just react. So installing just the peers won't install e.g. `react-dom`. So I guess having it the way you got it now...

We actually still have the problem. Changing the UID/GID to `0` is not an option as we run on `65532`. But to answer the question yes it does work with...

Can somebody review [this](https://github.com/callumlocke/soup/pull/4). If the pull request in `soup` get merged, it would be possible to add this functionality here in `gulp-cdnify`

Following works for me: ```js const FBLoginManager = NativeModules.MFBLoginManager; ... async componentDidMount() { const fbView = Platform.OS === 'ios' ? FBLoginManager.LoginBehaviors.Web : FBLoginManager.LoginBehaviors.WebView; await FBLoginManager.setLoginBehavior(fbView); } ``` But it is...

I would propose a new theme configuration. I think with these everything should be covered: ``` { codeBlockOptions: { // this identifies if the code block should be wrapped or...