Joe Kribs

@LePips no rush since this only impacts tvOS / Main. I've built this out more. Instead of hardcoding YouTube, I made a real `DeepLinkURL` Struct for this. Testing and working...

> I'm curious what happens if those apps are not installed... will the user be prompted to install them? Right now it errors with: "Unable to open trailer in ApplicationName"...

> Whether or not we should link to external apps for trailers feels like more of a server question. Since the server currently supports it I'd say it's a net...

I just did some cleanup to fix the complexity warning. Please let me know if we'd prefer the original "complex" route instead. This new route doesn't trigger the complexity warning...

> @LePips maybe you forgot about this PR. Don't want to disturb but I am anxious about the next tvOS release since we don't have TestFlight for tvOS. This one...

Sorry about that delay! @LePips ready when you are! Tested on real hardware using Vimeo and YouTube. I tried to make `ExternalTrailerSource`.`SourceType` as easy to maintain/add to as possible. I...

I *had* a source in my notes but am now getting: I agree that we should only use vetted links. I'm loading this up on my tv now and I...

Okay, I've tested what I could. Part of my issue is that some of these I am able to get it to open the apps but I can't check if...

> Instead of relying on deep links, can we just use Universal Links (for apps/sites that support them)? https://developer.apple.com/documentation/xcode/allowing-apps-and-websites-to-link-to-your-content/ We are already using Universal Links in iOS and they do...

Functional for both IPv4 and IPv6. This recovers if there are issues and appropriately displays errors / loading. The only thing I don't love.... I ran into this error: https://github.com/apple/swift-nio/issues/1494....