J0J0 Todos
J0J0 Todos
I'd like to implement this, but am poking around kind of blindly currently :-) I need some advice @sampsyo, not urgent at all just if you find the time and...
@sampsyo thanks, that was excatly the information I needed to get started. @wargreen and @sampsyo It turns out adding simple mappings is not as straight forward as it seemed on...
Hi @wargreen thanks so much for getting back to me. Appreciated. Could you please move your answer to the PR over here: https://github.com/beetbox/mediafile/pull/59 (and then delete it in this beets...
@wargreen should we close this one? since ab being discontinued, I've closed my pr around this feature already...sorry to see ab go but it is what it is :-(
If we look at the plain api response of aforementioned release: https://api.discogs.com/releases/21846394, we see that the first artist contains `"join": "Feat"`, the second artist does not contain that: ``` "artists":...
@sampsyo do you agree that the best option would be to use the new p3dc attribute artists_sort and let the beets user configure whether artist names should simply be joined...
Ah good thinking, thanks! I double checked and yes indeed "Beatles, The" is what's containend in `artists_sort` for a good ol' Beatles release. Alright so then it's settled, I'll use...
Fun fact @sampsyo, the original PR implementing a first version of Discogs source plugin, already respected the join field in the Discogs API result: https://github.com/beetbox/beets/pull/283/files#diff-c9f257e23ad1ebab4dafc681c7e0a22d3f7432eb8664e06cd7cf84ce5fc426d9R114-R115 At some point the get_artist...
The alternative, in case we'd like to keep `MetadataSourcePlugin.get_artist()` as-is, would be to do something like this within the Discogs plugin: ``` # Why not use artists_sort, get_artist handles moving...
Example import with last "workaround" solution: ``` (beets) ~/git/beets fix_discogs_multi_artist ● beet import ~/Sync/beets_test_music/DJ\ Marky\ -\ LK /home/jojo/Sync/beets_test_music/DJ Marky - LK (2 items) Finding tags...