J0J0 Todos

Results 310 comments of J0J0 Todos

> I think anoter possible way to avoid this could also be adding an option for "vinyl_disc_number: no" to the plugin, for those who are encountering issues with it, or...

> Yes, that's sort of the logic I think I'm going to switch it to, but it also has to support all the digital track index standards too. 😔 >...

Thanks for the submission. And yeah we have this eg for discogs and spotify, but there it's easier since eg one discogs track is on one album, there is no...

maybe add some notes where -s is described around here: https://beets.readthedocs.io/en/latest/reference/cli.html#id2

I'm sure this is not the right way to fix this. Some eyes here @semohr or @snejus. Here we assert False, I suppose because this should never happen right? https://github.com/beetbox/beets/blob/2bd77b9895fa9779818ff1c0430b9f9738d1616b/beets/importer/tasks.py#L241-L254

> @JOJ0 Do you have the full trace-back here? How do we even run into this? This is a quite old part of the codebase, how was this never an...

There might be some design-flaws that slipped through my initial review of this plugin. One thing is that the listener here is of no use if the configuration of the...

> Have you seen #6211? Would that approach also fully fix this issue? Yes definitely. Closed that one already. It's definitely correct to simply "not do prevent suggest stuff" if...

I applied the mentioned fix and rebased. Remains to be decided if we want to change things in the importer's `imported_items()` method or not @semohr @Serene-Arc

> I applied the mentioned fix and rebased. Remains to be decided if we want to change things in the importer's `imported_items()` method or not @semohr @Serene-Arc For now I...