Jones
Jones
So you want to keep everything as it is? Why do we rewrite mybb then? We want to have a modern and easy to use forum software which allows the...
We should also move the logic somewhere else, atm all querying happens in the controller.
TODO: conversations and the memberlist should be searchable too.
Is `,` allowed in a username in 1.x? If yes, the same bug likely applies there, if not we shouldn't allow it in 2.x too.
Then we should forbid it here too - and probably some other characters.
A few further improvements: Cache as much as possible, especially in the MCP. I'd guess a few queries will be cached after fixing #149 but it should be rechecked though....
Just a note to whoever implements this: Old captchas need to be deleted too (https://github.com/mybb/mybb/blob/feature/inc/tasks/hourlycleanup.php#L44-L46)
Do you also plan to add activities here (posting topic/post) or will you add it separately? Also you changed the getPresenter in the Post model but not in the others.
@euantorano Is this still wip or can we start testing it? (After resolving conflicts)
We have a lot of things which don't follow our current t standards - all of them should be fixed in one go in a separate PR. About injecting the...