WIP remove OBlock Reporter Edit tab

[icklesteve]

Removes Reporter tab from edit OBlock. See https://groups.io/g/jmriusers/message/222967

[mergeable[bot]]

Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file.

[icklesteve]

Restarting headless CI following timeout

[INFO] Running jmri.jmrix.roco.z21.Z21LocoNetTunnelTest
Error: The operation was canceled.

[dsand47]

Should the reporter load and store be removed from jmri.jmrit.logix.configurexml.OBlockManagerXml?

After removing the edit capability, the reporter value will always be null so there is no risk. However, in the future it might cause confusion.

[bobjacobsen]

I don't use OBlocks, so I might not understand the underlying issue. But was it just that the schema didn't properly verify when a reporter reference was present?

[dsand47]

I don't use OBlocks, so I might not understand the underlying issue. But was it just that the schema didn't properly verify when a reporter reference was present?

Reporter support was added in 2013, but the traditional OBlock edit process did not include reporters so there was never a reference to a Reporter object. The OBlock schema was not updated to include the reporter element.

The tabbed OBlock edit process was added in 2020. This was a clone of the Block edit process which includes the Reporter tab.

Other than the reporter edit tab and the load/store references, a search of jmri.jmrit.logix finds no references to reporters.

@petecressman might be a better resource.

[icklesteve]

Marking WIP pending clarification of whether

A - Reporters can pass info to OBlocks, the code was never completed ( update OBlock xml schema to allow Reporters )

B - Reporters cannot pass info to OBlocks ( also remove Reporters from jmri.jmrit.logix.configurexml.OBlockManagerXml )

[dsand47]

There is a third scenario,

OBlock extends Block so the data passing is not an issue. As far as I can tell, the OBlock/Portal/OPath/Warrant system makes no use of reporter data. If this is true and there is no plan to use Reporter data, then option B is appropriate.

----- Original message ----- From: Steve Young @.> To: JMRI/JMRI @.> Cc: Dave Sand @.>, Review requested @.> Subject: Re: [JMRI/JMRI] remove OBlock Reporter Edit tab (PR #12623) Date: Friday, November 17, 2023 2:58 AM

Marking WIP pending clarification of whether

A - Reporters can pass info to OBlocks, the code was never completed ( update OBlock xml schema to allow Reporters )

B - Reporters cannot pass info to OBlocks ( also remove Reporters from jmri.jmrit.logix.configurexml.OBlockManagerXml )

— Reply to this email directly, view it on GitHub https://github.com/JMRI/JMRI/pull/12623#issuecomment-1815976797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AED27YFGLGFL2JZ4WWF5DILYE4RMDAVCNFSM6AAAAAA7MD6IJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVHE3TMNZZG4. You are receiving this because your review was requested.Message ID: @.***>

[danielb987]

What's the status of this PR?

[petecressman]

I can suggest one possible implementation for Reporters of OBlocks. They could message the change of state of the OBlock much like what the "Allocated To" and the "Occupied By" columns do. BTW, there are several other columns (fields) in the table that are not used in any implementation that I know of. Most of these are hidden as the default.I suppose I was thinking that any field inherited by Oblock from Block could be edited by a user, if the field was not reserved for internal use only and could possibly be used to configure the layout. My suggestion would be to make the "Reporter" and "Speed Notch" columns hidden as the default also.

On Tuesday, December 19, 2023 at 07:56:25 AM PST, Daniel ***@***.***> wrote:  

What's the status of this PR?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity.

[github-actions[bot]]

This PR was closed because it has been inactive for 30 days since being marked as stale.