PyDMX icon indicating copy to clipboard operation
PyDMX copied to clipboard

Making the variable DMX_MAX_ADDRESS modifiable?

Open Speldosa opened this issue 1 year ago • 2 comments

I'm using a modified version of PyDMX in my program where I've changed the DMX_MAX_ADDRESS variable in core/dmx/constants.py from 512 to 96 (since I'm only using a single light with 96 addresses anyway). This makes my program run significantly faster.

Would it be possible and desirable to enable some sort of option where this value can be changed by the end user without they having to modify the source code?

Also, while on the topic: In core/dmx/light.py, DMX_MIN_ADDRESS and DMX_MAX_ADDRESS are being defined in the file itself rather than being imported from core/dmx/constants.py as is the case in core/dmx/interface.py and core/dmx/universe.py. I don't know if this is intentional (I guess not), but they are set to the same values as in core/dmx/constants.py anyway, so I guess they should be imported from there instead.

Speldosa avatar Aug 09 '22 00:08 Speldosa