ktlint-gradle icon indicating copy to clipboard operation
ktlint-gradle copied to clipboard

Add `--binary` when creating patch for unstaged files

Open GrahamBorland opened this issue 1 year ago • 4 comments

This fixes the pre-commit hook to cope with unstaged binary files. Without this option, the hook fails when there is an unstaged binary file.

error: cannot apply binary patch to 'some/binary/file' without full index line
error: some/binary/file: patch does not apply

GrahamBorland avatar Sep 06 '22 10:09 GrahamBorland

Sorry it's taken so long to get back to you on this. I'm happy to merge this, but I need an entry in the changelog file. After that, more than happy to merge this!

JLLeitschuh avatar Mar 31 '23 19:03 JLLeitschuh

Changelog entry added, thanks!

GrahamBorland avatar Apr 01 '23 10:04 GrahamBorland

Looks like CI is failing for this PR. Can you take a look?

JLLeitschuh avatar Apr 04 '23 11:04 JLLeitschuh

Once CI is passing, I'm more than happy to merge this 😃

JLLeitschuh avatar Apr 04 '23 11:04 JLLeitschuh