FTX.Net icon indicating copy to clipboard operation
FTX.Net copied to clipboard

Published 20 hours ago • verified publisher icon JKorf

ModifyOrderByClientOrderIdAsync should take a string for clientOrderId

Open kevindarby opened this issue 2 years ago • 0 comments

Describe the bug I believe the IFTXClientTradeApiTrading.ModifyOrderByClientOrderIdAsync interface and impl should take a string for clientOrderId (the first argument)

To Reproduce See here: https://github.com/JKorf/FTX.Net/blob/e38290c128eba63a40b371db76cf97ce95937e04/FTX.Net/Interfaces/Clients/TradeApi/IFTXClientTradeApiTrading.cs#L104

clientOrderId is declared as a long

Expected behavior clientOrderId is a string in the cancel and place methods, so it should probably be a string here.

kevindarby avatar Aug 10 '22 22:08 kevindarby