Binance.Net icon indicating copy to clipboard operation
Binance.Net copied to clipboard

Added Gift Card Endpoints Support

Open ShrewdLuni opened this issue 1 year ago • 5 comments

Summary:

  • Implemented Gift Card endpoints in BinanceRestClientGeneralApiGiftCard class

Added:

  • Interfaces:
    • IBinanceRestClientGeneralApiGiftCard
  • Models:
    • BinanceGiftCardData
    • BinanceGiftCardRedeemData
    • BinanceGiftCardResponse
    • BinanceGiftCardTokenLimit
    • BinanceGiftCardValidity

DOCS

ShrewdLuni avatar Apr 20 '25 21:04 ShrewdLuni

The RSA encryption for gift card redemption is implemented directly within the RedeemGiftCard method rather than in a separate utility class or method. This approach was chosen because:

  1. This is the only place in our codebase where this specific encryption is needed (as far as I am concerned)
  2. It keeps the related code together in one place, improving readability
  3. The encryption is relatively simple and self-contained

ShrewdLuni avatar Apr 20 '25 22:04 ShrewdLuni

Have a look at the warnings please

JKorf avatar Apr 28 '25 06:04 JKorf

Have a look at the warnings please

Can you be a bit more specific please, I do not have any in my IDE, what should I look at?

ShrewdLuni avatar Apr 28 '25 10:04 ShrewdLuni

If you look at the Files Changed here in the Github PR you'll see 2 warnings

JKorf avatar Apr 28 '25 12:04 JKorf

If you look at the Files Changed here in the Github PR you'll see 2 warnings

both are fixed now

ShrewdLuni avatar Apr 29 '25 15:04 ShrewdLuni