Changes to logLevels
Simple pull request to change logLevels (This PR is kind of opinionated).
Changes:
- Route creations are now on the
INFOlevel (changes made to the .md and the seed file too) - Request are on the
INFOlevel too - Request results are on the
NOTElevel
This is to comply with le descriptions of INFO as being minor informations and NOTE as being verbose.
An argument could be made that the route creations should be on the NOTE level but since it only concerns a single batch output at the beginning of the execution and that this information can be useful to ensure that everything went well without being too verbose I believe the INFO level is appropriate.
Feel free to ask me to change my PR if you don't agree !
Codecov Report
Merging #251 into master will not change coverage. The diff coverage is
50.00%.
@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 24 24
Lines 2805 2805
=======================================
Hits 2286 2286
Misses 519 519
| Impacted Files | Coverage Δ | |
|---|---|---|
| utilities/rest-helper-factory.js | 80.39% <0.00%> (ø) |
|
| utilities/handler-helper.js | 78.82% <66.66%> (ø) |
|
| utilities/handler-helper-factory.js | 93.13% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a911ade...6fdb815. Read the comment docs.