toxic icon indicating copy to clipboard operation
toxic copied to clipboard

Fix problem with Clang build

Open xWNgLWT0mQf opened this issue 4 years ago • 3 comments

Fix inclusion of NAME_MAX and PATH_MAX macros. On Linux they are defined at <linux/limits.h> On Apple they may be defined at <sys/sysinfo.h>, if possible please check the apple definitions.

Signed-off-by: Josiah Mullins [email protected]

xWNgLWT0mQf avatar Aug 12 '21 21:08 xWNgLWT0mQf

It seems that GCC automatically sets PATH_MAX and NAME_MAX while Clang does not.

xWNgLWT0mQf avatar Aug 12 '21 21:08 xWNgLWT0mQf

I have never had any issues with these defines when compiling with either GCC or Clang. Can you post the errors you were getting?

JFreegman avatar Nov 05 '21 18:11 JFreegman

I apologize for the delay in my response. I hope that you find what you are looking for in the following bug. https://bugs.gentoo.org/803404

xWNgLWT0mQf avatar Nov 08 '21 00:11 xWNgLWT0mQf

Closing this for inactivity. I've still never heard of anyone else having issues with this on any system - it's most likely an issue with your own environment. Please re-open in https://github.com/TokTok/toxic/ if you're still having trouble.

JFreegman avatar Jan 25 '24 18:01 JFreegman