Height mismatch among different controls

[runiter]

Different controls seem to have different default heights. See different height of Button vs ChoiceBox vs ColorPicker:

[MairwunNx]

Work in progress.

[dukke]

This might be related to issue #64 since a bigger font will also make the control bigger. So we probably should start by fixing that issue and then coming back to this one and see if this one still applies.

[dukke]

I've pushed this #65 This theme tester will work as a framework to fix this alignment, size, fonts problem. This tester will also be good to test other things.

[dukke]

..to be more precise there's a "Alignment test" tab that has various controls layed out and shows how they align with each other.

[dukke]

This is almost finished in https://github.com/JFXtras/jfxtras-styles/releases/tag/5.4 Some small tweaks are still needed, so I'll still be working to fix this issue.

[runiter]

Thanks very much for fixing the issues I reported previously. Both font and control size look great now. Also the white background issue is "almost" fixed.

Here's the result I get now which is much better than before:

But I notice a white line on the left side of "Graph" tab. Looks like the TabPane still uses white background around the padding area.

Seems like you are already aware of this problem from the issue reported here:

https://github.com/JFXtras/jfxtras-styles/issues/100

Thanks for the ongoing improvements.

[dukke]

Thanks for the update!

#100 might actually be specific to ThemeTester app. If I run the TabPaneSample app in dark mode it doesn't have that issue.

Do you have the TabPane inside any Pane? If you do, the background of the Pane below might be showing through.. You can try adding the style-class "background" to that Pane so it has the default background of JMetro. Alternatively set the automaticallyColorPanes property of JMetro to true which will automatically set all the Panes backgrounds (you may then need to revert the ones you don't want to be colored automatically by setting the background to transparent or some other color).