42_EXAM icon indicating copy to clipboard operation
42_EXAM copied to clipboard

Exam Rank 5

Open karimomino opened this issue 1 year ago • 1 comments

When ASpell and ATarget dont have virtual destructors the submission fails as expected, however the trace provided is incorrect Expected :

cpp_module01/main.cpp:21:3: error: delete called on non-final 'Fwoosh' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
  delete fwoosh;

Received

<--------------~-~-~-~-~-~-~-~-~------------>
Richard: This looks like another boring day.$
Richard: I am Richard, the Titled!$
Target Practice Dummy has been fwooshed!$
Richard: My job here is done!$
\n
<--------------~-~-~-~-~-~-~-~-~------------>\n\n
<--------------~-~-~-~-~-~-~-~-~------------>
Richard: This looks like another boring day.$
Richard: I am Richard, the Titled!$
Target Practice Dummy has been fwooshed!$
\n
<--------------~-~-~-~-~-~-~-~-~------------>

karimomino avatar Sep 06 '23 18:09 karimomino

The trace doesn't log errors. I kept failing module01, apparently i didn't have to delete the spells in forgetSpell function, only in destructors.

SkyHearts avatar Feb 07 '24 04:02 SkyHearts