node-libcurl icon indicating copy to clipboard operation
node-libcurl copied to clipboard

Add prebuilt binaries for nodejs 20 LTS

Open bchew opened this issue 1 year ago • 10 comments

nodejs 20 has just been moved to active LTS and we have just realised there were no prebuilt binaries after upgrading as per snippet below (similar to the issue with nodejs 18 last year):

npm ERR! node-pre-gyp info using [email protected] | linux | x64
npm ERR! node-pre-gyp info check checked for "/home/node/e2e/node_modules/node-libcurl/lib/binding/node_libcurl.node" (not found)
npm ERR! node-pre-gyp http GET https://github.com/JCMais/node-libcurl/releases/download/v3.0.0/node_libcurl-v3.0.0-node-v115-linux-x64-glibc.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/JCMais/node-libcurl/releases/download/v3.0.0/node_libcurl-v3.0.0-node-v115-linux-x64-glibc.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v115 ABI, glibc) (falling back to source compile with node-gyp) 
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/JCMais/node-libcurl/releases/download/v3.0.0/node_libcurl-v3.0.0-node-v115-linux-x64-glibc.tar.gz

Would it be possible to have prebuilt binaries for 20 as well? That would be appreciated, thanks.

bchew avatar Oct 25 '23 21:10 bchew

Hey!

I will try to add the prebuilt binaries next weekend, I will update this if I am able to do so

JCMais avatar Oct 30 '23 19:10 JCMais

Excellent @JCMais !

Just ask if you need any help :)

Cheers, David

ddolcimascolo avatar Nov 02 '23 11:11 ddolcimascolo

Hi @JCMais,

Did you manage to build the library for Node 20?

Thanks, David

ddolcimascolo avatar Nov 06 '23 08:11 ddolcimascolo

No, there are some build issues that I will have to fix throughout the week

JCMais avatar Nov 06 '23 12:11 JCMais

Yeah, for zlib I see that Node 20 returns a weird version number that makes the build fail because no corresponding tag exists in the zlib repo...

$ node -e "console.log(process.versions.zlib)"
1.2.13.1-motley

ddolcimascolo avatar Nov 07 '23 09:11 ddolcimascolo

Hi all,

For the record, I did setup a build of the native addon using zlib 1.2.13 (as per my comment above) and libcurl 7.86.0 using a private, custom CI job on a Linux x64 container (based on Debian 11, my primary target). Build passed with a few warnings and our test suite is all green.

David

ddolcimascolo avatar Nov 09 '23 22:11 ddolcimascolo

Hi @JCMais

Really looking forward to the support for NodeJS 20.

Thanks, Pankaj

pankaz avatar Nov 26 '23 12:11 pankaz

I released a pre-release version of node-libcurl that has prebuilt binaries Node.js v20, it is available through node-libcurl@next, feel free to try it out and report any issues.

This pre-release version will probably become the v4 version of the package, there are no API-breaking changes thus far, and the only reason for the new major version will be the drop of support for old node versions.

JCMais avatar Dec 17 '23 19:12 JCMais

@JCMais, thank you so much for this fix. I will check this out and revert if I come across any issues.

pankaz avatar Dec 18 '23 07:12 pankaz

@JCMais we've tested the pre-release version and it's working as expected. Thanks again for sorting this out, much appreciated.

bchew avatar Jan 09 '24 04:01 bchew

Hey @JCMais, how is the progress on bumping the next version to latest?

kdev avatar Feb 01 '24 17:02 kdev

@kdev looks like 4.0.0 has just dropped 🎉:

  • https://github.com/JCMais/node-libcurl/releases

nktnet1 avatar Feb 12 '24 03:02 nktnet1

https://github.com/JCMais/node-libcurl/releases/tag/v4.0.0

bchew avatar Feb 12 '24 08:02 bchew