Juan Cruz comments

Results 36 comments of


                                            Juan Cruz

feat: refs for linked issues in conventional commit parser

Yes, I'm trying to read it because what I wanted was to put in each commit the task that had led to adding that change.

feat: refs for linked issues in conventional commit parser

Yeah, I think that would be the best way for customers to complete the changelog correctly and then be able to add that automatic closing functionality.

feat: refs for linked issues in conventional commit parser

I have uploaded the adapted tests and different types of refs that could be used. Should I add closed_issues to this PR? Or should this go in another one?

feat: refs for linked issues in conventional commit parser

And so would the PR be valid, or would some change need to be made?

feat: refs for linked issues in conventional commit parser

Hi @codejedi365 Do you need me to change anything else?

Bug: Incorrect type annotation of `allow_methods`

I just realized that I answered with my work account and not my personal one hahahaha. Looking at it more carefully, if we want to make this change we should...