Jaap Aarts

Results 111 comments of Jaap Aarts

Thanks for the PR, I added a parallel example. While doing so I realised the parallel test was completely wrong and parallel functions did not work at all, so I...

Uhh oops, I mean review instead of PR

I started adding more tests, and I found one really odd error. On the latest commit, if you switch around the arguments to `SetValue` for the chunk test, it returns...

It was a long road, but a lot of things had to happen for this to be mergable :)

@taniabogatsch I think the last remaining question is, is the schema actually usefull? Should it be kept in the API or removed. Besides that I think this is ready for...

I have a very busy couple of weeks ahead, generally this semester is quite full with projects so little time for this ATM. (I've tried to bump my duckdb extension...

> The mappings are not a separate package; they're just a few files with build constraints in the main go-duckdb package. Should they also be moved to a separate package...

Nice work! Must have been a pain to work on this

I don't have much time ATM, but this weekend I will look at this and give a review.

I have one small nit, it would be really nice to have an error-less way to create supported types. That is the reason I implemented ways to create duckdb types...