OpenJK icon indicating copy to clipboard operation
OpenJK copied to clipboard

[MP] reconcile game module changes with the original source releases by diffing codemp/game

Open Razish opened this issue 1 year ago • 1 comments

Main changes:

  • revert saberMoveData changes to match basejka, provide a new cvar (g_fixSaberMoveData) to patch it if desired
  • introduce a new configstring (26: CS_LEGACY_FIXES) to inform the client of which fixes it should also apply, e.g. saberMoveData
  • ~client module obtains gamestate (including configstrings) earlier to prevent use before initialisation, which is now checked for in debug builds~ reverted due to bugs
  • revert a change to saber disarm bonus calculation if g_fixSaberDisarmBonus is not enabled
  • G_CanBeEnemy considers private duels once again (removed from jasdk_modbase before its git history)

Razish avatar Oct 08 '23 12:10 Razish

So, what's missing, or what do you plan to add? What's the current state of this?

SomaZ avatar Feb 19 '24 11:02 SomaZ

This is ready to go. Oops, didn't realise I still had the big scary label still applied.

I have two follow-up branches locally that build on top of this

Razish avatar Feb 20 '24 01:02 Razish

Have been running this in TaystJK for quite some time, we had issues until we got the gamestate earlier as already applied to this PR. Have not had any issues since.

taysta avatar Feb 20 '24 04:02 taysta