cookies icon indicating copy to clipboard operation
cookies copied to clipboard

Critical issue parsing cookie

Open RubieV opened this issue 9 years ago • 3 comments

I have issues getting an URL encoded cookie containing numbers and a comma; resulting in a NaN value. I have had to replaced your Native_isNaN, which is deprecated by jQuery and is not used correctly in this context.

RubieV avatar Apr 30 '16 22:04 RubieV

I'll need a little help in understanding the issue you're having and how you remedied it.

First, can you please give me an example of a cookie you're setting which then retrieves improperly?

Second, notice that Native_isNaN is a reference to JavaScript's built in isNaN. I capture that reference, then build my own isNaN inside my library's scope. The latter defers to the former when conditions require. With all of that said, I'm interested to know why you believe I am not using it correctly, and in seeing the code change you made. I'd also be grateful for any reference you can provide on jQuery having deprecated something.

Thanks very much, Jim

JAAulde avatar May 21 '16 15:05 JAAulde

I've switched to js-cookie.

Do you have unit tests available? Setting cookies went fine, their values were url encoded and stored in the browsers cookie store. Yet, retrieving causes exceptions to be thrown. Might it be newer JS versioins or browser implementations?

I'm unable to find the jQuery docs, I'm sorry I'm unable to help you further.

RubieV avatar May 22 '16 14:05 RubieV

I do have some tests I run, but nothing as solid or formal as I'd like.

I am going to re-open this issue and examine it further. I understand you've changed libraries and don't have much to gain here, but can you provide me a cookie value that would fail?

Thanks very much, Jim

JAAulde avatar May 22 '16 15:05 JAAulde