Little-Anti-Cheat
Little-Anti-Cheat copied to clipboard
J-Tanzanite
Fix 1.11 compile errors.
You're quoting https://github.com/alliedmodders/sourcepawn/issues/613 which appears to be reversed.
It shouldn't break on compile anymore, so is this PR really needed?
For now the "fix" is on the dev branch, I'm using latest compiler and it's still errors, i guess it's up to the repo owner to accept it or not, i don't mind.
Oh, so in the 1.11 development version of Sourcemod, using int instead of any in timers causes errors?
Skimming through the discussion you link to, it seems like they decided not to do this?
Not gonna lie, I'm a little confused... @~@
I'll happily accept this PR if this change really does end up happening to SM, but I'll wait a bit and see if it becomes necessary first. Still, thanks for the PR and the heads up :) :+1:
Oh, so in the 1.11 development version of Sourcemod, using
intinstead ofanyin timers causes errors?
In the 1.11 development version this problem is fixed.
Skimming through the discussion you link to, it seems like they decided not to do this? Not gonna lie, I'm a little confused... @~@
The change is already made in the main branch, latest complier errors. (i had a problem with my GitHub workflow that's pulling the latest compiler and compiles plugins, this plugin failed because the errors above)
I'll happily accept this PR if this change really does end up happening to SM, but I'll wait a bit and see if it becomes necessary first. Still, thanks for the PR and the heads up :) 👍
You can accept and revert if they fix it in the future but you can let this boil until they push an update and reject it, I'm cool with both, or anything you wanna do.
I have decided to merge this. But I would prefer if this could be applied to the development branch. Could you start a PR for that branch? If not, I can do it manually :P
Anyway, thanks for this PR, sorry for having been so slow to respond '^^
Oh right, I forgot this PR existed, just fixed it myself in #150 Closing as this is no longer needed, sorry for the delay and for having done it myself.