react-three-legacy icon indicating copy to clipboard operation
react-three-legacy copied to clipboard

Incompatible with React 16

Open danyim opened this issue 8 years ago • 5 comments

I am getting the following error when attempting to use this library in my React 16 project: Module not found: Can't resolve 'react-dom/lib/ReactCompositeComponent'

Does this project share the same technical reason why react-three-renderer can't support v16? https://github.com/toxicFork/react-three-renderer/issues/197

danyim avatar Oct 26 '17 00:10 danyim

Yeah, the rewrite of React for v16 changed a lot of internals. I don't have the free time I once did so the rewrite will be a long time coming. I should update the README.

Izzimach avatar Oct 27 '17 14:10 Izzimach

I had a reason to upgrade to React 16, and ran of course in to the above problem.

Any update? Anything I can do to help?

eeh avatar Dec 04 '17 13:12 eeh

@eeh Rewrite the codebase to use Fiber :P But seriously, what would be best is to contribute to react-three-renderer as they're farther along in getting it implemented than this project.

danyim avatar Dec 04 '17 18:12 danyim

Yeah, R3R is pretty similar to react-three so you should be able to switch over and it looks like they are actively moving toward getting React 16 to work.

Izzimach avatar Dec 05 '17 16:12 Izzimach

Can anyone recommend react-three-fiber versus react-three-renderer?

wayofthefuture avatar May 27 '19 22:05 wayofthefuture