Arclight icon indicating copy to clipboard operation
Arclight copied to clipboard

[1.16.5] Worlds Behavior is extremly wrong! GameRules, DayCycle, ClimateCycle!

Open EverNife opened this issue 1 year ago • 11 comments

I have confirmed that ...

  • [X] Arclight is up to date
  • [X] all dependencies are installed
  • [X] all plugins and mods are up to date
  • [X] unable to reproduce in Spigot
  • [X] unable to reproduce in Forge

Arclight version

arclight-forge-1.16.5-1.0.25-SNAPSHOT

OS & Java versions

OS: Windows, jdk-11.0.12.7-hotspot

Plugins and Mods

Pixelmon

Basic plugins like Vault, LuckPerms, and a few private ones!

Description

Ok, there are many ~~problems and are probably all related to the same cause.~~ I was not able to fully understand what is causing it though.

[1] All GameRules are not PER_WORLD, they are PER_SERVER, so there is no way to, for example, enable KeepInventory in a specific world and keep it disable in another world. [2] Changing time in any world does not work, you can only change time on the MAIN WORLD. [3] Changing weather in any world does not work, you can only change weather on the MAIN WORLD. [4] Changing any of these on the MAIN WORLD will reflect on all worlds, so, lets say you set time to 0 on the main World, all other dimesions will have its time set to 0. [5] If you set time to main world and go to another world, and se time there, and go back to the main world, the set time will not work anymore, not even on the main world.

The image bellow i set time to DAY but there is no change to it. image

The example code bellow will not work if you are not on the main dimension: (to be honest after some teleporation, not even on the main dimension anymore)

player.getWorld().setTime(0); //Will only work if you are on the MAIN_WORLD, otherwise will have no effect.
player.getWorld().setGameRule(GameRule.KEEP_INVENTORY, false); //Will change on all worlds, not only the world you are in!


And why worlds are called like this?

pixelmon/ultra_space
//and with symlinks
world_pixelmon_ultra_space

That is a lot contra-intutive! Is there a reason for that? Why not just use the ending of the name-space like

pixelmon:ultra_space --> ultra_space


Because of these crazy namings datapack worlds will not works properly on! If you want i may open a separated issue for Datapack worlds, but if the dimesion has the same type as OverWorld it will receive the Overworld name, so, we end up with like 4 Worlds called "world"

I am making a few tests chaning the world names to see what happens, but i think there are several points here that are a little bit crazy.

But at least i was able to make datapack overworlds work with archligh by just fixing the nammings

image

Step to reproduce

No response

Logs

No response

Server pack link (Optional)

No response

EverNife avatar Feb 28 '23 09:02 EverNife