Arclight icon indicating copy to clipboard operation
Arclight copied to clipboard

Published 20 hours ago • verified publisher icon IzzelAliz

(1.16.5) Vanish not working... (bug)

Open Chazzie opened this issue 2 years ago • 19 comments

I have confirmed that ...

  • [X] all plugins and mods are up to date
  • [X] unable to reproduce in Spigot
  • [X] unable to reproduce in Forge

Arclight version

arclight-1.16.5-1.0.23-daa3c8bb

OS & Java versions

Java: openjdk version "11.0.13" 2021-10-19

Plugins and Mods

CMI
CMILib

Description

when trying to run any vanish plugins their command it just doesn't put us in vanish.. it makes us go invisible for 1 second then after that it makes us visible again without noticing us. i tried it with CMI and also other plugins and all the same result.

Step to reproduce

  1. install any Vanish Plugin

  2. try to run their /vanish command

  3. try to see if another player sees you (in my case they could see me)

Logs

No response

Server pack link (Optional)

No response

Chazzie avatar Jul 16 '22 17:07 Chazzie

Got the same issue.

Arclight version: arclight-1.16.5-1.0.23-daa3c8bb Plugin using: protocollib build 595 & premium vanish 2.7.17

image

DustSwiffer avatar Aug 13 '22 14:08 DustSwiffer

Can confirm this issue with SuperVanish and VanishNoPacket. Would be nice if it can be fixed, because vanish is important for admins and commonly used.

GodMorduk avatar Aug 24 '22 15:08 GodMorduk

Can it be reproduced on 1.18

timi137137 avatar Aug 24 '22 16:08 timi137137

Can it be reproduced on 1.18

i got no idea about that. we want to run ArcLight for our Pixelmon Reforged server

Chazzie avatar Aug 24 '22 17:08 Chazzie

Can it be reproduced on 1.18

i got no idea about that. we want to run ArcLight for our Pixelmon Reforged server

i am sorry, but i must to tell you. Pixelmon module in arclight 1.16 maybe have very more problem, in 1.18 maybe not problem.

timi137137 avatar Aug 24 '22 17:08 timi137137

If you can reproduce the problem in 1.18, we can fix it quickly and fix it in 1.16

timi137137 avatar Aug 24 '22 17:08 timi137137

i tried it without even pixelmon installed and it didn't even work then like with an completely new server

Chazzie avatar Aug 24 '22 17:08 Chazzie

ok,i got it，we will quickly and fix it, thank you help

timi137137 avatar Aug 24 '22 17:08 timi137137

thanks a lot

Chazzie avatar Aug 24 '22 17:08 Chazzie

@timi137137 sorry for tagging but any chance of getting this fixed anytime soon?

aglarcz avatar Nov 01 '22 00:11 aglarcz

Hi, I've found the same problem here. I've done some testing and I believe it might be related to the mixins Arclight applies to either the Entity or LivingEntity classes from Bukkit. SuperVanish uses Player::hidePlayer internally.

I've done the following tests on clean servers, which included either SuperVanish/VanishNoPacket (Bukkit plugins) or Vanishmod (Forge mod). Note that the tests for each of those was done separately when using Arclight (meaning only SuperVanish or only Vanishmod was loaded at the same time):

The following tests were updated on August 8, 2023. The previous tests can be found on the comment history.

  • Arclight 1.18/1.0.9 (MC 1.18.2):
    • SuperVanish v6.2.18 and ProtocolLib v5.1.0: player is invisible for ~1s and then is shown again to everyone in-game and the tab list but it does get hidden in the server list player count.
    • VanishNoPacket v3.22: untested, probably same result as SuperVanish due to using similar API.
    • Vanishmod 1.18.2-v1.1.12: player is hidden successfully in-game and in tab list, but not in the server list player count.
  • Arclight Horn/1.0.1 (MC 1.19.2):
    • SuperVanish v6.2.18 and ProtocolLib v5.1.0: player is invisible for ~1s and then is shown again to everyone in-game and the tab list but it does get hidden in the server list player count.
    • VanishNoPacket v3.22: generated exception on load: java.lang.NoClassDefFoundError: net/kyori/adventure/text/Component, player is invisible for ~1s and then is shown again to everyone in-game, tab list and server list player count.
    • Vanishmod 1.19.2-v1.1.12: player is hidden successfully in-game and in tab list, but not in the server list player count.
  • Arclight GreatHorn/1.0.2 (MC 1.19.3):
  • Arclight Executions/1.0.5 (MC 1.19.4):
    • SuperVanish v6.2.18 and ProtocolLib v5.1.0: generated exception on server ping: Unable to construct new instance using public net.minecraft.network.protocol.status.ServerStatus(net.minecraft.network.chat.Component,java.util.Optional,java.util.Optional,java.util.Optional,boolean,java.util.Optional), player is invisible for ~1s and then is shown again to everyone in-game, tab list and server list player count.
    • VanishNoPacket v3.22: generated exception on load: java.lang.NoClassDefFoundError: net/kyori/adventure/text/Component, player is invisible for ~1s and then is shown again to everyone in-game, tab list and server list player count.
    • Vanishmod 1.19.4-v1.1.12.1: player is hidden successfully in-game and in tab list, but not in the server list player count.
  • Arclight Trials/1.0.0 (MC 1.20.1):
    • SuperVanish v6.2.18 and ProtocolLib v5.1.0: generated exception on server ping: Unable to construct new instance using public net.minecraft.network.protocol.status.ServerStatus(net.minecraft.network.chat.Component,java.util.Optional,java.util.Optional,java.util.Optional,boolean,java.util.Optional), player is invisible for ~1s and then is shown again to everyone in-game, tab list and server list player count.
    • VanishNoPacket v3.22: generated exception on load: java.lang.NoClassDefFoundError: net/kyori/adventure/text/Component, player is invisible for ~1s and then is shown again to everyone in-game, tab list and server list player count.
    • Vanishmod 1.20.1-v1.1.12.1: player is hidden successfully in-game and in tab list, but not in the server list player count.
  • Spigot, locally built (MC 1.20.1):
    • SuperVanish v6.2.18 and ProtocolLib v5.1.0: player is hidden successfully from all places (in-game, tab list and server list player count).
    • VanishNoPacket v3.22: generated exception on load: java.lang.NoClassDefFoundError: net/kyori/adventure/text/Component, but player does get hidden correctly except from server list player count.
  • PaperMC build #126 (MC 1.20.1):
  • Forge v47.1.1 (MC 1.20.1, same Forge version as the build used for Arclight Trials/1.0.0):

I'll attach some videos of the testing done with SuperVanish and Vanishmod on 1.18.2 so that the weird behavior that is only present in all the tested versions of Arclight can be seen.

Arclight 1.18/1.0.9, SuperVanish v6.2.18 and ProtocolLib v5.1.0

I unfortunately forgot to include the test for the server list player count.

https://github.com/IzzelAliz/Arclight/assets/7624090/bcc0852d-715c-43f4-b255-1182cc1a0602

Arclight 1.18/1.0.9, Vanishmod 1.18.2-v1.1.12

I unfortunately forgot to include the test for the server list player count.

https://github.com/IzzelAliz/Arclight/assets/7624090/18b089e9-ea29-4f41-a77e-70038de2afad

All the config files were used with the generated defaults, except for disabling online-mode in server.properties to test locally using offline accounts.

Looking at the source code of VanishNoPacket, it seems to be using a newer API instead of a deprecated overload of Player::hidePlayer, but it still has the same result as SuperVanish (which is still using the deprecated method).

I might add more combinations of server versions/software/plugins/mods later, but as I mentioned before I've already spent too much time here.

I currently don't have the knowledge to contribute to the project since I haven't dealt with mixins before but I'm happy to provide any logs or help with testing as needed.

dalbitresb12 avatar Jan 19 '23 13:01 dalbitresb12

bump?

Mike5357 avatar Mar 03 '23 20:03 Mike5357

Any updates on this?

OakLoaf avatar Mar 30 '23 20:03 OakLoaf

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 07 '23 05:08 stale[bot]

This issue is not stale, I've just updated my previous comment to include testing with the latest versions of Arclight that still have this bug.

dalbitresb12 avatar Aug 14 '23 07:08 dalbitresb12

This is still pretty major bug, and a massive problem for server administrators. Can you please look into fixing this? @timi137137

b0hle avatar Sep 20 '23 14:09 b0hle

Vanish working as intended with this mod https://modrinth.com/mod/vanishmod/version/v1.1.6 its serverside only so you can use it as plugin - just put it into mods folder.

aglarcz avatar Sep 20 '23 16:09 aglarcz

@aglarcz As mentioned in my previous comment, the issue is with Bukkit plugins, not with the Forge mod. Those are the ones that are not working.

dalbitresb12 avatar Sep 20 '23 16:09 dalbitresb12

I know, just giving admins some options to use.

aglarcz avatar Sep 20 '23 17:09 aglarcz