ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

[BUG] Money in a specific account did not change anymore

Open Suien-UTTU opened this issue 1 year ago • 16 comments

Please confirm the following

Describe the bug

I don't know when it happened but today when I check the account I find the Bank account balance is wrong, and I cannot change the balance even if I add a expense or a income. The INCOME and EXPENSES in balance will change but the BALANCE just keep the same. I try the demo at GitHub but still the same.

To Reproduce

Expected behavior

No response

Screenshots

Screenshot_20240719_112002_Ivy Wallet Demo Screenshot_20240719_111949_Ivy Wallet Demo

App version

V2024.7.14 from Google play

Smartphone

No response

Additional context

No response

Suien-UTTU avatar Jul 19 '24 03:07 Suien-UTTU

Thank you @Suien-UTTU for raising Issue #3352! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ivywallet avatar Jul 19 '24 03:07 ivywallet

Well I just notice all the account balance remains now. Actually, I can make sure I used it as usually an hour before, and other accounts also work well, only one account not work. But now, all together.

Suien-UTTU avatar Jul 19 '24 03:07 Suien-UTTU

It's a timezone issue. Transactions get added to the "future" which isn't included in the balance calculation

ILIYANGERMANOV avatar Jul 19 '24 08:07 ILIYANGERMANOV

For more context, the is likely:

  • Transaction time is saved as local time (+/- X UTC)
  • The account balance query uses (0 UTC)
  • Only happened transactions before "now" are included in the balance calculation

Hence the recent transaction is not included because it appears to be in the future.

ILIYANGERMANOV avatar Jul 19 '24 08:07 ILIYANGERMANOV

It seems the bug appeared after this PR https://github.com/Ivy-Apps/ivy-wallet/pull/3351 @ILIYANGERMANOV

PrathakGarg avatar Jul 29 '24 11:07 PrathakGarg

It seems the bug appeared after this PR #3351 @ILIYANGERMANOV

@PrathakGarg is it certain? If so I can revert it

ILIYANGERMANOV avatar Jul 29 '24 11:07 ILIYANGERMANOV

Revert PR opened: https://github.com/Ivy-Apps/ivy-wallet/pull/3380

ILIYANGERMANOV avatar Jul 29 '24 11:07 ILIYANGERMANOV

@ILIYANGERMANOV I'm not very familiar with this repo so I can't be sure but it does make sense. And the timing of the appearance of the bug matches too

PrathakGarg avatar Jul 29 '24 11:07 PrathakGarg

Yeah, makes sense - can you try testing the APK from the revert PR?

ILIYANGERMANOV avatar Jul 29 '24 11:07 ILIYANGERMANOV

I won't be able to right now

PrathakGarg avatar Jul 29 '24 11:07 PrathakGarg

No worries^ I'll merge it and our community can test

ILIYANGERMANOV avatar Jul 29 '24 11:07 ILIYANGERMANOV

@Suien-UTTU If you could try the latest release from github and see if the issue persists as some fixes were made that could have fixed this issue. PS - The fix is not on Play Store yet.

suyash01 avatar Aug 06 '24 19:08 suyash01

Yeah I try it and it seemed work now. Thanks for your support!

Suien-UTTU avatar Aug 14 '24 18:08 Suien-UTTU

@suyash01 @Suien-UTTU could I get the apk to use right now since this update is still not on the Play Store

PrathakGarg avatar Aug 23 '24 09:08 PrathakGarg

@PrathakGarg get the APK from the latest Release on GitHub, it should be new enough

ILIYANGERMANOV avatar Aug 23 '24 10:08 ILIYANGERMANOV

@ILIYANGERMANOV I just tested the latest released apk. This issue is still there. Please look into it

PrathakGarg avatar Aug 23 '24 13:08 PrathakGarg