ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

[BUG] DATE PROBLEM

Open hkjansonchan opened this issue 10 months ago • 4 comments

Please confirm the following

Describe the bug

I just input the date & time eg 18 May 7.00am But after I confirmed the date become 17 May and I press in it, It was 18 May 7.00am That's weird

To Reproduce

Expected behavior

No response

Screenshots

No response

App version

4.6.3(163) from Play Store

Smartphone

Samsung Galaxy A54

Additional context

No response

hkjansonchan avatar Apr 17 '24 23:04 hkjansonchan

Thank you @hkjansonchan for raising Issue #3145! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ivywallet avatar Apr 17 '24 23:04 ivywallet

@hkjansonchan can you please add more details/screenshots and the steps to reproduce the issue.

This is how I tried to reproduce it. It is working as expected.

https://github.com/Ivy-Apps/ivy-wallet/assets/54620116/5fef1062-1c83-4fca-b4ee-901c149ed501

sufyan-siddiqui avatar Apr 18 '24 13:04 sufyan-siddiqui

It's a timezone issue. Set your device to GMT+8 or some big difference from UTC and it'll break.

We need to work everywhere with Instant (UTC) and convert to LocalDateTime only in the UI layer when we format Instant -> String.

ILIYANGERMANOV avatar Apr 18 '24 14:04 ILIYANGERMANOV

Same problem. The transaction history screen seems to be using the GMT+0 timezone no matter what.

palapapa avatar Apr 23 '24 07:04 palapapa

I'm on it

rishi2062 avatar May 26 '24 11:05 rishi2062

Thank you for your interest @rishi2062! 🎉 Issue #3145 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar May 26 '24 11:05 ivywallet

@ILIYANGERMANOV is this issue still open after my merge ?

rishi2062 avatar Jun 01 '24 21:06 rishi2062