RecurrentComplex icon indicating copy to clipboard operation
RecurrentComplex copied to clipboard

Structures are broken with Sponge API world-gen. Compatibility Issue

Open Thanatosus opened this issue 6 years ago • 9 comments

Hello,

I've tried to create a Sponge-Forge server with your nice mod but I've fell in a quiet nasty bug.

It appears that when you try to generate a new world in Forge-moded Minecraft with the Sponge API installed the structures are completely broken like this :

2018-04-18_14 53 43

I didn't put any others mods on the server side and I'm using the latest recommanded build of Forge (1.12.2 - 14.23.3.2655) and the stable Sponge build for 2655 Forge (1.12.2-2655-7.1.0-BETA-3025 yeah it's marked BETA but Sponge put it in stable category).

I also had a lot of errors in the logs like :

[FML]: Recurrent Complex loaded a new chunk [-18, 15] in dimension 0 (overworld) while populating chunk [-17, 15], causing cascading worldgen lag. [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config. (I put the log files here so) latest.log

And in the debug file we clearly see that the generation is KO (ex. line 12619): debug.log

[14:52:55] [Server thread/TRACE] [reccomplex]: GenericTreeHuge canceled generation at BlockPos{x=118, y=75, z=318} (0) (failed to place) [14:52:55] [Server thread/TRACE] [reccomplex]: GenericTree3 canceled generation at BlockPos{x=127, y=77, z=333} (0) (failed to place)

Without Sponge API everything is generated correctly.

Also I put here a bug report on Sponge GitHub made by another user and where Sponge indicates that's this don't come from them : https://github.com/SpongePowered/SpongeForge/issues/1949

Thank you for reading this report and also for your work on this nice mod which adds so needed structures variants in Minecraft. Hope that this information was helpful for you.

Have a nice day, Thanatosus

Thanatosus avatar Apr 18 '18 13:04 Thanatosus

" Also I put here a bug report on Sponge GitHub made by another user and where Sponge indicates that's this don't come from them "

... No where in that issue is that stated. We don't yet know the cause.

ryantheleach avatar Jul 30 '18 20:07 ryantheleach

This still seems to be an issue using latest versions of Sponge and RC. It is mentioned in this issue: https://github.com/SpongePowered/SpongeForge/issues/1949 that a fix might come with a future Forge version. So, maybe after Sponge moves past 2705?

Rutes avatar Oct 19 '18 02:10 Rutes

To clarify my test results, versions used below. RC seems to play nice with all the other mods in my pack - just not Sponge.

I tried tweaking the structure-saving section of sponge\global.conf, but it had no effect.

Only workaround I can think of for now is to fly around, pre-generating the world without sponge and then enabling it later.

forge-1.12.2-14.23.4.2705 spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar RecurrentComplex-1.4.7.jar IvToolkit-1.3.3-1.12.jar

Not really sure if this should be considered a RecurrentComplex issue or a Sponge issue. As mentioned in a recent comment on https://github.com/SpongePowered/SpongeForge/issues/1949 this could maybe be fixed with a future version of Forge?

For reference, my complete modlist on server-side: [1.12]MoVillages-1.5.4.jar animania-1.12.2-1.5.1.1.jar AppleCore-mc1.12.2-3.1.4.jar applejuiceskin-1.12.2-1.0.0.4.jar AppleSkin-mc1.12-1.0.9.jar bearwithme-1.12.2-1.3.1.jar BetterAdvancements-1.12.2-0.0.5.17.jar BetterWithLib-1.12-1.5.jar BetterWithMods-1.12-2.3.15.jar BiomesOPlenty-1.12.2-7.0.1.2399-universal.jar ClayWorldGen-1.1.0-1.12.0.jar Clumps-3.1.1.jar CoralReef-2.5-1.12.2.jar corpsecomplex-1.12.2-1.0.3.jar CraftStudio-1.0.0.93-mc1.12-alpha.jar culinaryconstruct-1.2.0.1.jar CustomNPCs_1.12.2(26aug18).jar diethopper-1.1.jar disenchanter-[1.12]1.6.jar DungeonTactics-1.12.2-0.15.6.jar EconomyLite-7.1.0-2.15.1.jar Electroblob's Wizardry - 4.1.2 - MC 1.12.2.jar extraalchemy-0.3.8.6.1-release.jar fairylights-2.1.4-1.12.2.jar FamiliarFauna-1.12.2-1.0.10.jar FastLeafDecay-v14.jar griefprevention-1.12.2-4.3.0.653.jar Guide-API-1.12-2.1.6-61.jar HelpFixer-1.12.1-1.5.18.jar HorsePower-1.12.2-2.6.1.68.jar iceandfire-1.5.2.jar ikwid-1.0.2.jar InventoryTweaks-1.63.jar IvToolkit-1.3.3-1.12.jar jei_1.12.2-4.12.1.217.jar LangSwitch-1.2.jar latch-0.4.8.jar llibrary-1.7.15-1.12.2.jar LuckPerms-Sponge-4.2.17.jar minecolonies-1.12.2-0.9.4-RELEASE-universal.jar MMCRestrict-1.5.1-API-7.jar MmmMmmMmmMmm-1.12-1.14.jar NaturesCompass-1.12.2-1.5.1.jar NoMobSpawningOnTrees-1.2.2-mc1.12.2.jar Nucleus-1.6.0-PR2-S7.0-MC1.12.2-plugin.jar parry-1.0-hotfix.jar PayDay-1.4.0.jar realistic-cobwebs-1.12.1-1.0.3.jar RecurrentComplex-1.4.7.jar RoguelikeDungeons-1.12.2-1.8.0.jar rustic-1.0.12.jar SimpleCorn1.12-1.12-2.4.1.jar skylands-1.5.5.jar solcarrot-1.12.2-1.3.3.jar SpartanShields-1.12.2-1.4.1.jar stg-1.12.2-1.2.3.jar tombstone-3.2.2-1.12.jar toroquest-1.12.2-5.2.jar Totemic-1.12.2-0.11.3.jar ToughAsNails-1.12.2-3.1.0.115-universal.jar UltimateChat-1.8.8-b196-Universal.jar UltimateChat-JDA.jar Vampirism-1.12.2-1.4.7.jar VampirismIntegrations-1.12.2-1.0.0.jar vanillafoodpantry-mc1.12.2-4.2.1.jar Waystones_1.12.2-4.0.67.jar webslinger-1.12.2-2.2.4.jar wolfarmor-1.12.2-2.2.3.1798-universal.jar worldedit-forge-mc1.12-6.1.8-dist.jar wumpleutil-1.12.2-2.12.6.jar

and my latest.log in case it is helpful: https://gist.github.com/Rutes/f7baf5bae241ef8f9004501991d59f42

Rutes avatar Oct 19 '18 03:10 Rutes

Just tried testing again today with the latest Sponge for Forge 2768 - same problem. Is there any other useful data I could gather to track down whether the issue lies with Sponge, RecurrentComplex, or Forge itself?

Rutes avatar Oct 19 '18 22:10 Rutes

One of Sponge's member seems to find out what's going on, here's the issue on the sponge's page https://github.com/SpongePowered/SpongeForge/issues/1949#issuecomment-547729492

ken1882 avatar Oct 31 '19 13:10 ken1882

no news about that? i've the same issue on last version but I use biomes o plenty with ReC ReC 1.4.8.2 Sponge 1.12.2-2838-7.2.1 and Forge 2838

firefloc avatar Jun 01 '20 21:06 firefloc

I was having the same issue for a long time, but I read that spongeforge changes generation and is likely to be the issue. So, even though I had a bunch of mods that required spongeforge I decided to remove spongeforge form my mods folder (both server and client) just to see what happened (I was expecting for it to crash and say that some mods needed spongeforge), but everything loaded and worked correctly with no errors. I made a creative world and flew around to generate some villages in order to see if it worked and I found a bunch of villages all of which generated correctly. So try removing spongeforge from your mods folder and see what happens, that should fix the issue.

DanSchlac avatar Jul 03 '20 16:07 DanSchlac

@DanSchlac man i wan't to be rude. Do you really propose to delete a spongeforge in the problem where I need to HAVE the spongeforge?

Thanatosus avatar Jul 03 '20 17:07 Thanatosus

I don't know how or why, but when I removed spongeforge from my mods folder, without doing anything else nor putting it back, village structure generation started working correctly. I didn't do anything other than just remove spongeforge. Surprisingly everything, including other mods that required spongeforge, still worked properly. It easily worked for me, and since I was having the same issue as others here, I thought I would share my findings. I can't guarantee that it will work, but I can recommend it, as it worked for me.

DanSchlac avatar Jul 05 '20 01:07 DanSchlac