diskusage icon indicating copy to clipboard operation
diskusage copied to clipboard

Analysing /data with root enabled does not work anymore

Open Massedil opened this issue 2 years ago • 9 comments

I tried the 5.0-alpha0 on F-Droid and I can't see my files when I try to show /data partition.

It was working with the 3.8.0 version.

Phone: Samsung Galaxy S5 LineageOS : 18.1

Massedil avatar Dec 07 '23 12:12 Massedil

Screenshot_20231207-134018_Trebuchet Screenshot_20231207-134030_Trebuchet

Massedil avatar Dec 07 '23 12:12 Massedil

Does it work on an older version of diskusage on the same device? I don't have access to rooted devices at this point, so my debugging abilities are limited and the code for capturing this state is removed now.

On Thu, Dec 7, 2023 at 11:42 PM Massedil @.***> wrote:

Screenshot_20231207-134018_Trebuchet.png (view on web) https://github.com/IvanVolosyuk/diskusage/assets/20357783/f23499c6-b710-479d-821c-92b3bd707d0f Screenshot_20231207-134030_Trebuchet.png (view on web) https://github.com/IvanVolosyuk/diskusage/assets/20357783/9d77861b-c761-4fda-bbab-7aae2f1f5a65

— Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/issues/87#issuecomment-1845275761, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HLXVPTOISSXJZRTRTLYIG2RTAVCNFSM6AAAAABAK7XWWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGI3TKNZWGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

IvanVolosyuk avatar Dec 08 '23 02:12 IvanVolosyuk

Does it work on an older version of diskusage on the same device?

Yes, it works with the 3.8.0 F-Droid version.

Massedil avatar Dec 08 '23 10:12 Massedil

The only bug with 3.8.0 is that 2 same folders (but mounted twice with different names) are counted twice instead of one.

/data/data and /data/user/0 are the same folder.

Here is 3.8.0 on the same device :

Screenshot_20231208-120219_Trebuchet

Massedil avatar Dec 08 '23 11:12 Massedil

Same issue as this ticket and same issue with the old version:

The only bug with 3.8.0 is that 2 same folders (but mounted twice with different names) are counted twice instead of one.

phone: Fairphone 3 Android 13 (LineageOS for microG 20) encrypted

I tried various other entries like "/data/user/0" and it doesn't data either.

tuxayo avatar Dec 08 '23 20:12 tuxayo

The issue with limited access to /data can be worked around by calling magisk su with

  -mm, -M,
  --mount-master                Force run in the global mount namespace

And the app should check for and not follow symlinks (like /data/user/0 -> /data/data)

binarynoise avatar Dec 13 '23 08:12 binarynoise

Patches are welcome.

On Wed, Dec 13, 2023 at 7:46 PM binarynoise @.***> wrote:

The issue with limited access to /data can be worked around by calling magisk su with

-mm, -M, --mount-master Force run in the global mount namespace

And the app should check for and not follow symlinks (like /data/user/0 -> /data/data)

— Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/issues/87#issuecomment-1853493366, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HILNUM6ZKEPCF73BHLYJFTPDAVCNFSM6AAAAABAK7XWWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGQ4TGMZWGY . You are receiving this because you commented.Message ID: @.***>

IvanVolosyuk avatar Dec 13 '23 09:12 IvanVolosyuk

It seems, the problem is not only the restricted access to /data. When running the native lib manually, it segfaults immediately, not even printing the "Need directory argument" error. As I don't know how to debug that, I have to pass the issue to someone who does. I could however push my change to use --mount-master

binarynoise avatar Dec 16 '23 16:12 binarynoise