ProToots icon indicating copy to clipboard operation
ProToots copied to clipboard

Add Hovercards

Open ItsVipra opened this issue 1 year ago • 3 comments

This PR adds the option to have a mini version of a user's profile show up on hover. Styling is mostly copied from the instance, with a few manual tweaks. Exactly what is shown in the profile is customizable. Additionally, profiles are cached for 24h as to reduce both API requests and load times. Currently only works in the home timeline and not on expanded posts. Has not been tested in advanced mode or glitch-soc much (help is appreciated).

image

ItsVipra avatar Aug 14 '23 16:08 ItsVipra

notices problem immediately after opening PR Cache includes instance specific URLs - this creates a problem for multi-instance users, as images may be blocked when on a different instance than the one the cache entry is from.

also the banners on glicht soc are broken :c

ItsVipra avatar Aug 14 '23 16:08 ItsVipra

regarding your comment @nachtjasmin do you mean setting the positions via css variables instead of inline? seems doable, but is that something users would want to override with an userstyle? i guess giving people the option doesn't hurt 🤔 changing the bio overflow to hidden via a class is definitely doable though

by translation do you mean language translation or positional translation? cause i don't see why we would need to translate the text in our addon - and if so why start with this one specific button?

ItsVipra avatar Sep 08 '23 20:09 ItsVipra

don't remember why I wrote that, I think, it was related to the gradient and all that static stuff.

And I meant language translation, but you're right, why start now. Let's keep it simple. ^^

nachtjasmin avatar Sep 09 '23 03:09 nachtjasmin