Overwatch-Script-To-Workshop icon indicating copy to clipboard operation
Overwatch-Script-To-Workshop copied to clipboard

Incorrect output for default workshop custom settings

Open SlenderFox opened this issue 1 year ago • 3 comments

After creating a workshop custom setting you can then specify the default values in customGameSettings.json, however the values this outputs are wrong.

customGameSettings.json: image Produces this output: image

customGameSettings.json: image produces this output: image

Expected output: image

SlenderFox avatar Jun 16 '24 09:06 SlenderFox

Could you please provide an example of when the last Expected Output should be expected? I am unfamiliar with any situations where the Overwatch Workshop outputs a setting as an array with one element.

CactusPuppy avatar Jun 16 '24 19:06 CactusPuppy

Did some more experimenting with this, the expected output is produced specifically with WorkshopSettingCombo, when custom game settings are copied while the values are set to something other than default. The copied settings are correctly decompiled into the settings.json but incorrectly compiled back into the overwatch format. A similar issue also happens with WorkshopSettingInteger and WorkshopSettingReal; the values are incorrectly trailed with a % like #493.

SlenderFox avatar Jun 17 '24 16:06 SlenderFox

I think all these LobbySettings issues can somehow be linked together and they're either being caused by the same or by a related bug. I haven't looked at the custom settings, but for the map and ult names I've been trying quite a few things for a while now and I am unable to find anything that has an actual effect on the compiled .ow script yet. There seems to be some functionality in place to replace certain characters like ( ) and , but I don't see it actually happening. I tried adding more of them at values, titles, resolved and translated names, but so far I don't see anything happening at all doing that.

The only thing I found that has effect on things like map and ult names are the JSON files that come along with the binaries. Changing the names there will also change them in the compiled scripts, but they will also be different in the de-compiled scripts and I am not sure if that's gonna cause any other issues. I'll try to have another go at it later some time.

damagex avatar Jul 28 '24 01:07 damagex