acf-gutenblocks icon indicating copy to clipboard operation
acf-gutenblocks copied to clipboard

Published 20 hours ago • verified publisher icon ItinerisLtd

PHP 8.* compatibility

Open lukasbesch opened this issue 1 year ago • 4 comments

lukasbesch avatar Jul 11 '23 11:07 lukasbesch

composer.lock

Dev Package changes

Package Operation From To Changes
roave/security-advisories upgrade dev-master 598b39c dev-master bcc78ca diff

Settings · Docs · Powered by Private Packagist

private-packagist[bot] avatar Jul 11 '23 11:07 private-packagist[bot]

Anything else you want to add to this before I merge @lukasbesch?

codepuncher avatar Jul 11 '23 13:07 codepuncher

We could add type declarations instead of doc blocks for the class properties.

Will look into #37 (or #38 now) again at some point, because I just saw it being flagged in my IDE.

Other than that, I am just picking up an older project with Sage 9 at the moment, and will see if I run into more (actual) issues on PHP 8 and the current WordPress version.

So maybe leave it unmerged for now, I will give you an update in the following days.

lukasbesch avatar Jul 11 '23 13:07 lukasbesch

We could add type declarations instead of doc blocks for the class properties.

I fully agree with this.

So maybe leave it unmerged for now

Up to you mate; I'm happy to merge now if you want to submit a new PR for types.

codepuncher avatar Jul 11 '23 13:07 codepuncher