android-training-2017 icon indicating copy to clipboard operation
android-training-2017 copied to clipboard

Published 20 hours ago • verified publisher icon IstiN

HW07 30.10.17

Open Dzmitry-Lakisau opened this issue 7 years ago • 3 comments

https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/master/README.md

Dzmitry-Lakisau avatar Nov 10 '17 22:11 Dzmitry-Lakisau

  1. Naming convention

  2. Repackage : package.name. data. model, api, db .... ui. login, home, detail activity, fragment, util

  3. ApiException : move message mapping upper to UI level (think about localization, resources)

  4. About dialog remove unused views

  5. Data: split to Model (POJO), DataLoader, HttpClient, Api (generate url), Parser, ImageLoader

  6. Constants

  7. Move async task from activity

TreeMap?

alexdzeshko avatar Nov 13 '17 16:11 alexdzeshko

@alexdzeshko Concerning Imageloading. Is it better to make like in this two classes: https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/refactor/app/src/main/java/by/d1makrat/library_fm/ImageDownloaderFromNetwork.java https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/refactor/app/src/main/java/by/d1makrat/library_fm/AppSettings.java ? Something needs to be improved?

Dzmitry-Lakisau avatar Nov 13 '17 18:11 Dzmitry-Lakisau

There will be a lesson about image loading next week, so skip this topic until it.

alexdzeshko avatar Nov 14 '17 11:11 alexdzeshko