DiztinGUIsh icon indicating copy to clipboard operation
DiztinGUIsh copied to clipboard

publish patched bsnes-plus and asar bundle

Open binary1230 opened this issue 4 years ago • 2 comments

One of the main new features I added was the ability for Diz to talk over a local TCP socket connection to BSNES-plus, and receive compressed CDL/tracelog data in realtime.

I opened a PR at bsnes-plus, and while my code is very functional, it's not polished enough to go into upstream yet. https://github.com/devinacker/bsnes-plus/pull/268

I think for a 2.0 release of Diz, what we should do is make a bundle that takes my two patches for bsnes-plus and asar, and ships those with Diz as the officially supported partner tools. For now, we'll have to build both of those tools ourselves but, as the patches get merged back upstream [hopefully, someday], then we can go back to just linking to the stock versions.

So this task is:

  1. build a copy of the patched bsnes-plus
  2. build a copy of the patched Asar
  3. Create a package with those and Diztinguish

binary1230 avatar Oct 29 '20 05:10 binary1230

So, pretty cool, I enabled AppVeyor builds for my forks of BSNES-plus and Asar, so the hard part of this is already done.

Example: Build artifacts available here: BSNES patched version: https://ci.appveyor.com/project/binary1230/bsnes-plus/builds/36053121 Asar patched version: https://ci.appveyor.com/api/buildjobs/tghuwdiogt50387r/artifacts/bsnes%2Fout%2Fbsnes-plus-v05.1-master.zip

Eventually (hopefully) those changes will be merged and the need for maintaining a separate bundle goes away

binary1230 avatar Oct 30 '20 14:10 binary1230