ISLE
ISLE copied to clipboard
Add the ability to pull isle_drupal_build_tools from any repository, and branch
Please add an environment variable that permits users to
- [x] Set their own repository to clone drupal_build_tools(https://github.com/Islandora-Collaboration-Group/isle_drupal_build_tools) on ISLE-Apache start
- [x] Additionally create a variable so users are not forced to use the master branch to permit testing of different configurations, etc.
In development build, commit: https://github.com/Islandora-Collaboration-Group/isle-apache/commit/930f43c8b6a2409250d812f030696d4659cac33b
Variables added: PULL_ISLE_BUILD_TOOLS = bool (true|false), default: true ISLE_BUILD_TOOLS_REPO = string, default: https://github.com/Islandora-Collaboration-Group/isle_drupal_build_tools.git ISLE_BUILD_TOOLS_BRANCH = string, default: master
@br2490 Will you or @marksandford document how an enduser can change the ISLE_BUILD_TOOLS_REPO
variable settings?
There is a lot more to this than simply changing a git URL right?
Reviewing the current README
for https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools does not give any indication how an enduser is supposed to use this repository so this feature may not be easily adopted?
Don't get me wrong, I like what everyone has done here and what has been gathered so far however this looks like a potential "last mile" documentation issue too.
Assuming steps are similar to:
- enduser makes a copy / forks the
https://github.com/Islandora-Collaboration-Group/isle_drupal_build_tools.git
- enduser makes appropriate modifications to said scripts within? The
README
should have a process and edit workflow to this effect. - enduser changes
ISLE_BUILD_TOOLS_REPO = string, default: https://github.com/enduser_customized_repo/isle_drupal_build_tools.git
Not clear where this change would be made in theisle-apache
image build area? @br2490 thoughts on where this changes?
[EDIT] @br2490 Okay so this variable /change is called here? https://github.com/Islandora-Collaboration-Group/isle-apache/pull/1/commits/7511ae4c80b6226d3972f6349f45d6ece042fbf2#diff-d05c1c2d65ed8806ae9c095e1c10af74
- enduser runs modified script.
So this is a multi prong to do then?
- Add the feature to change install tools
- Add documentation for this type of customization
- Update the current Readme to the https://github.com/Islandora-Collaboration-Group/isle_drupal_build_tools.git to explain what tools are available and how to customize
- Perhaps a version log and release notes for these tools above?