Ishadijcks.github.io icon indicating copy to clipboard operation
Ishadijcks.github.io copied to clipboard

Randomize mine items only in places it can fit. Hence fix 0 item bug

Open fujnw opened this issue 5 years ago • 1 comments

This essentially combines https://github.com/Ishadijcks/Ishadijcks.github.io/commit/3ae3c9016fd4937fbba373b62dcbeddff3a1cb12#diff-179a97f89e4d8cc0cce87781606fe8b5 and https://github.com/Ishadijcks/Ishadijcks.github.io/pull/175/files to fix the underground.

Currently, underground randomizes items between 1 and max-3, then checks if items can fit. As a result, some larger items are not guaranteed to fit. Some people may be very unlucky and have all 3 of their items not fit and create the "zero items bug".

Here, we always guarantee the successful addition of the first item, by randomizing for spots that the item can fit.

Note: this is basically the same as https://github.com/Ishadijcks/pokeclicker/commit/afaf88de369cb317cf02765d4a70eaf78a097f65#diff-c337aaee8e9ee46ce006207353a43b08 in the TypeScript rewrite.

fujnw avatar Mar 17 '19 01:03 fujnw

Looks good!

Ishadijcks avatar Mar 17 '19 22:03 Ishadijcks