vs-preview icon indicating copy to clipboard operation
vs-preview copied to clipboard

Update comp plugin settings tab

Open LightArrowsEXE opened this issue 1 year ago • 1 comments

I was going to look at refactoring this further, but the workers file traumatised me. What the fuck is this code ~~jimbo~~ SETSU

This PR implements the following:

  • Updated comp plugin settings tab
    • Sort settings into categories
    • Lots of refactoring and add docstrings
    • Add more useful tooltips and instructions
    • Obfuscate the API key for security reasons
      • the one we're using globally is still easily accessible in the code, but users don't have to worry about accidentally sharing their own by screenshotting the window
    • Add a table showing all the collection name template placeholders
    • Add an example output of what the collection name the user passes will render as
      • (BUG): Very long name will fuck up rendering, but >user error imo
    • Adjust the layout a bit more so it looks nicer and is easier to navigate
    • Log warnings if there are issues with the API key
  • Refactoring of the utility functions, add docstrings
  • Rename clear_filename to sanitize_filename (way clearer what it's doing)
  • Add max retries to do_single_slowpic_upload so we don't spam their API.

Example:

image

LightArrowsEXE avatar Sep 08 '24 19:09 LightArrowsEXE

BTW {video_nodes} isn't the number of nodes. Its a "vs" separated list of all the nodes. For example "JPBD vs USBD vs WEB"

Kapppa avatar Oct 24 '24 08:10 Kapppa

Outdated, and changes have been made to the settings since. Closing.

LightArrowsEXE avatar Jan 06 '25 16:01 LightArrowsEXE