rivet icon indicating copy to clipboard operation
rivet copied to clipboard

[UI] Unclear that graphs cannot be reordered

Open scottbessler opened this issue 2 years ago • 4 comments

What happened?

With multiple graphs, when I drag graphs up/down with their drag handle it does not seem to actually reorder.

What was the expected functionality?

reorder the graphs

Describe your environment

MacOS

Relevant log output

none

Relevant screenshots

https://github.com/Ironclad/rivet/assets/293802/af99e73c-a3c7-41b8-8ba2-fa6ee027e76d

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

scottbessler avatar Aug 10 '23 18:08 scottbessler

It's not actually supposed to reorder, we keep it alphabetical on purpose (like a code editor list), the dragging is for moving stuff into folders. Maybe it should grey out stuff so people don't think they can reorder?

abrenneke avatar Aug 10 '23 18:08 abrenneke

I've disabled highlighting the current folder when dragging does that help? In 2f46db54417a1d5ced2684d91facaca4e0c735b3

abrenneke avatar Aug 10 '23 21:08 abrenneke

ahh, makes sense. maybe we should use a generic file icon instead of that drag handle thing, usually that drag handle implies ordering (at least according to my brain)

scottbessler avatar Aug 21 '23 16:08 scottbessler

Hmm it should still be some sort of drag handle, because you do drag it, just only into folders. Maybe the drag handle should be removed and the whole thing should be draggable, like vs code

abrenneke avatar Aug 21 '23 17:08 abrenneke