Iris icon indicating copy to clipboard operation
Iris copied to clipboard

Light levels come already offset

Open BalintCsala opened this issue 1 year ago • 2 comments

What happened?

Light levels coming from gl_MultiTexcoord1 are in the wrong range, they're in [8, 248], this causes issues if someone relies on the minimum being 0.

Screenshots

No response

Log output

No response

Minecraft Version

1.21.2

Iris Version

1.8

Operating System

Windows 11

What is your GPU?

RTX 4070

Additional context

No response

BalintCsala avatar Oct 09 '24 20:10 BalintCsala

Can confirm. According to CaffeineMC/sodium/issues/2761, Sodium already clamped vanilla light level in vertex attributes to remove the clamp() in terrian shader. Jellysquid thought it doesn't hurt vanilla thing, so they suggest only fix it in Iris side. However, developers of Iris don't know this (or known but haven't decide to fix) for a long time.

Most visible artifact caused by this issue is light leaking fix underground using sky light level. The minimum 0.5 light level will just making those fix almost useless.

GeForceLegend avatar Dec 27 '24 16:12 GeForceLegend

An entire year unfixed and I might have only played MC for a couple hours this year tops, because of this

ToneyFoxxy avatar Nov 10 '25 05:11 ToneyFoxxy